1583030 - [meta] replace idl nsIArray usage with Array<T> in Thunderbird code

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Magnus Melin [:mkmelin]]

See bug 1550111 comment 0 and bug 1509978.
Usage if nsIArray in idls should be switched over to Array<T>. This will be much better ergonomics for js callers.

https://searchfox.org/comm-central/search?q=nsIArray&case=false&regexp=false&path=.idl

We should prioritize the ones with many callers first, like nsIMsgAccountManager.idl .
Once done fixIterator and friends can be eliminated: https://searchfox.org/comm-central/search?q=fixIterator&case=false&regexp=false&path=mail

Comment 1

[Ben Campbell]

I didn't originally spot that nsIMutableArray was derived from nsIArray. Those should all be replaced too...

Comment 2

[Ping Chen [:rnons] (away)]

Hi Ben, I'm going to implement nsISmtpService in JS in bug 1679730, then found readonly attribute nsISimpleEnumerator servers; https://searchfox.org/comm-central/rev/8a81725ff0230661a6a66f675c733d4b87645578/mailnews/compose/public/nsISmtpService.idl#90. Is there plan to migrate nsISmtpService.idl or maybe nsISimpleEnumerator is a separate issue? Thanks.

Comment 3

[Magnus Melin [:mkmelin]]

nsISimpleEnumerator is a different issue, which Ben is going to take on next. The usage you mentioned is indeed very pointless enumerator usage that is seems to do nothing except wrap an internal array to... make things harder.
I filed bug 1681031 for meta tracking that now.