1612686 - Get Smooshmonkey build and tests into CI

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jason Orendorff [:jorendorff]]

I don't know how to do this off-hand. We need a variant of our spidermonkey-plain scripts that runs the tests with --rust-frontend, and we need to add a task to CI.

So far we're using GitHub Actions for CI, but it doesn't run all the tests. It just does a build.

Comment 1

[Nicolas B. Pierron [:nbp]]

Steve, would you know who to contact or where to look to have a different build of SpiderMonkey on treeherder?

Comment 2

[Steve Fink [:sfink] [:s:]]

I can just do it. Is Linux-only ok? Is it useful/important to have both debug and opt builds?

Comment 3

[Steve Fink [:sfink] [:s:]]

It probably won't work, but my first attempt is https://treeherder.mozilla.org/#/jobs?repo=try&revision=deb1ce640010c1bbe5905190b4836e21e5efe87b (which is running all the spidermonkey jobs; I just wanted to be sure I didn't break any of the others.)

Comment 4

[Steve Fink [:sfink] [:s:]]

Oh, heh. Looks like that option hasn't landed yet? Anyway, I'll upload the patch for you to try.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1612686 - add SmooshMonkey tasks

Comment 6

[Nicolas B. Pierron [:nbp]]

I do not think rust-frontend repository got merged into mozilla-central yet, nor is jsparagus vendored yet.
Thanks for making the patch, this would be a good source of inspiration and I guess we can take over from here :)

Do you happen to know who should we ask for review once done?

Comment 7

[Steve Fink [:sfink] [:s:]]

(In reply to Nicolas B. Pierron [:nbp] from comment #6)

Do you happen to know who should we ask for review once done?

I think jmaher might be appropriate. Maybe?

Comment 8

[Tooru Fujisawa [:arai]]

I'll take this, with some patches moved from bug 1612515

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1612686 - Part 1: Fix autospider.py caller to set RUSTC/CARGO/CBINDGEN env. r?#build!

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1612686 - Part 2: Add SmooshMonkey tasks. r?#build!,sfink!

Depends on D64555

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ff2b33327cd
Part 1: Fix autospider.py caller to set RUSTC/CARGO/CBINDGEN env. r=glandium
https://hg.mozilla.org/integration/autoland/rev/8c5f225b1d3e
Part 2: Add SmooshMonkey tasks. r=sfink,jmaher

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9ff2b33327cd
https://hg.mozilla.org/mozilla-central/rev/8c5f225b1d3e