Closed Bug 1612515 Opened 5 years ago Closed 5 years ago

Land rust-frontend changes behind a configure flag

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: jorendorff, Assigned: arai)

References

Details

Attachments

(7 files, 8 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

The rust-frontend repository is a crude hack to get the new frontend bootstrapped, but I'd like to land those changes (without too much cleanup) behind a flag so that our team can work in mozilla-central. The rust-frontend repo will be retired.

For now, when you build with this flag, you'll have to specify the directory containing jsparagus, which contains the parser generator and many hand-coded Rust bits: the lexer, AST, AST builder, and emitter.

Making the user provide a jsparagus directory means we don't have to constantly land snapshots of it in mozilla-central. Later we'll have to do that.

Blocks: 1612686
Type: task → enhancement
Priority: -- → P1
Depends on: 1616161
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

Depends on D64157

Depends on D64167

Attachment #9128907 - Attachment is obsolete: true
Attachment #9128893 - Attachment description: Bug 1612515 - Part 5: Add --enable-smoosh configure option. r?jorendorff → Bug 1612515 - Part 6: Add --enable-smoosh configure option. r?jorendorff
Attachment #9128897 - Attachment description: Bug 1612515 - Part 6: Add ContextOptions.trySmoosh and --smoosh JS shell option. r?jorendorff → Bug 1612515 - Part 7: Add ContextOptions.trySmoosh and --smoosh JS shell option. r?jorendorff
Attachment #9128899 - Attachment description: Bug 1612515 - Part 7: Import the main SmooshMonkey change from rust-frontend. r?jorendorff → Bug 1612515 - Part 8: Import the main SmooshMonkey change from rust-frontend. r?jorendorff
Attachment #9128900 - Attachment description: Bug 1612515 - Part 8: Add smoosh optional dependencies to JS shell and browser. r?#build → Bug 1612515 - Part 9: Add smoosh optional dependencies to JS shell and browser. r?#build
Attachment #9128901 - Attachment description: Bug 1612515 - Part 9: Add a differential parser fuzzing test. r?jorendorff → Bug 1612515 - Part 10: Add a differential parser fuzzing test. r?jorendorff
Attachment #9128902 - Attachment description: Bug 1612515 - Part 10: Support cbindgen in JS automation. r?jorendorff → Bug 1612515 - Part 11: Support cbindgen in JS automation. r?jorendorff
Attachment #9128905 - Attachment description: Bug 1612515 - Part 11: Update vendored crates for smoosh and jsparagus. r?#build → Bug 1612515 - Part 12: Update vendored crates for smoosh and jsparagus. r?#build
Attachment #9129021 - Attachment is obsolete: true
Attachment #9128902 - Attachment is obsolete: true
Attachment #9128900 - Attachment is obsolete: true
Attachment #9128891 - Attachment is obsolete: true
Attachment #9128897 - Attachment description: Bug 1612515 - Part 7: Add ContextOptions.trySmoosh and --smoosh JS shell option. r?jorendorff → Bug 1612515 - Part 5: Add ContextOptions.trySmoosh and --smoosh JS shell option. r?jorendorff
Attachment #9128893 - Attachment description: Bug 1612515 - Part 6: Add --enable-smoosh configure option. r?jorendorff → Bug 1612515 - Part 6.1: Add --enable-smoosh configure option and smoosh optional dependencies to JS shell and browser. r?#build!. r?jorendorff
Attachment #9128899 - Attachment description: Bug 1612515 - Part 8: Import the main SmooshMonkey change from rust-frontend. r?jorendorff → Bug 1612515 - Part 6.3: Import the main SmooshMonkey change from rust-frontend. r?jorendorff
Attachment #9128905 - Attachment description: Bug 1612515 - Part 12: Update vendored crates for smoosh and jsparagus. r?#build → Bug 1612515 - Part 7: Add vendored crates for smoosh and jsparagus. r?#build!
Attachment #9128901 - Attachment description: Bug 1612515 - Part 10: Add a differential parser fuzzing test. r?jorendorff → Bug 1612515 - Part 8: Add a differential parser fuzzing test. r?jorendorff
Attachment #9128889 - Attachment description: Bug 1612515 - Part 3: Disassemble skeptically. r?jorendorff → Bug 1612515 - Part 3: Disassemble skeptically. r?jorendorff!
Attachment #9128893 - Attachment description: Bug 1612515 - Part 6.1: Add --enable-smoosh configure option and smoosh optional dependencies to JS shell and browser. r?#build!. r?jorendorff → Bug 1612515 - Part 6.1: Add --enable-smoosh configure option and smoosh optional dependencies to JS shell and browser. r?#build!,jorendorff.
Attachment #9128893 - Attachment description: Bug 1612515 - Part 6.1: Add --enable-smoosh configure option and smoosh optional dependencies to JS shell and browser. r?#build!,jorendorff. → Bug 1612515 - Part 6.1: Add --enable-smoosh configure option and smoosh optional dependencies to JS shell and browser. r?#build!,jorendorff!.
Attachment #9128885 - Attachment description: Bug 1612515 - Part 1: Add a JS shell primitive to list directory content from JavaScript. r?jorendorff → Bug 1612515 - Part 1: Add a JS shell primitive to list directory content from JavaScript. r?jorendorff!
Attachment #9128887 - Attachment description: Bug 1612515 - Part 2: Add JSContext* param to BCEScriptStencil::initAtomMap. r?jorendorff → Bug 1612515 - Part 2: Add JSContext* param to BCEScriptStencil::initAtomMap. r?jorendorff!
Attachment #9128897 - Attachment description: Bug 1612515 - Part 5: Add ContextOptions.trySmoosh and --smoosh JS shell option. r?jorendorff → Bug 1612515 - Part 5: Add ContextOptions.trySmoosh and --smoosh JS shell option. r?jorendorff!
Attachment #9128899 - Attachment description: Bug 1612515 - Part 6.3: Import the main SmooshMonkey change from rust-frontend. r?jorendorff → Bug 1612515 - Part 6.3: Import the main SmooshMonkey change from rust-frontend. r?jorendorff!
Attachment #9128901 - Attachment description: Bug 1612515 - Part 8: Add a differential parser fuzzing test. r?jorendorff → Bug 1612515 - Part 8: Add a differential parser fuzzing test. r?jorendorff!
Attachment #9128893 - Attachment is obsolete: true
Attachment #9128899 - Attachment is obsolete: true
Attachment #9129430 - Attachment is obsolete: true
Attachment #9128905 - Attachment description: Bug 1612515 - Part 7: Add vendored crates for smoosh and jsparagus. r?#build! → Bug 1612515 - Part 6: Import the SmooshMonkey change from rust-frontend. r?jorendorff!, r?glandium!
Attachment #9128901 - Attachment description: Bug 1612515 - Part 8: Add a differential parser fuzzing test. r?jorendorff! → Bug 1612515 - Part 7: Add a differential parser fuzzing test. r?jorendorff!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/c430b858a795 Part 1: Add a JS shell primitive to list directory content from JavaScript. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/9bddddd34411 Part 2: Add JSContext* param to BCEScriptStencil::initAtomMap. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/5c587f73b259 Part 3: Disassemble skeptically. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/7af4ab474159 Part 4: Move RunCBindgen.py to /build. r=glandium https://hg.mozilla.org/integration/autoland/rev/f2893156987f Part 5: Add ContextOptions.trySmoosh and --smoosh JS shell option. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/3930394edfa8 Part 6: Import the SmooshMonkey change from rust-frontend. r=jorendorff,glandium https://hg.mozilla.org/integration/autoland/rev/ee0769652fa1 Part 7: Add a differential parser fuzzing test. r=jorendorff
Depends on: 1619065
Blocks: smooshmonkey
Regressions: 1653212
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: