1612720 - Port |Bug 461013 - get rid of |aTab.localName != "tab"| checks in removeAllTabsBut, removeTab and reloadTab| and tidy up

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, task)

Description

[Ian Neal]

Port changes from:

• Bug 461013 - get rid of |aTab.localName != "tab"| checks in removeAllTabsBut, removeTab and reloadTab.

Also some tidy up:

• menu.setAttribute("disabled", foo) -> menu.disabled = foo
• matching reloadTab method with Firefox

Comment 1

[Ian Neal]

Attachment: Port changes

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9123948 [details] [diff] [review]
Port changes

LGTM 

One minor thing. I would put parentheses around the logical operators in menuitem.disabled:

+                menuitem.disabled =
+                    (tbattr.includes("tabbrowser-multiple") && !isMultiple) ||
+                    (tbattr.includes("tabbrowser-tab") && !isTab);

Precedence of Logical Operators is right and && higher but find it more readable this way. r/a+ either way.

Comment 3

[Ian Neal]

Attachment: Port changes v1.1

With changes as suggested, carrying forward r/a+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fd76d1b09482
Port |Bug 461013 - get rid of |aTab.localName != "tab"| checks in removeAllTabsBut, removeTab and reloadTab| and tidy up. r=frg