1612725 - download manager backend not initilaized if SeaMonkey is not started as normal browser (non private navigator) first

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Frank-Rainer Grahl (:frg)]

The sessionstore-windows-restored notification is not send if you start SeaMonkey with the private flag or with another component like mail/news. This means that the code in this._onBrowserStartup(subject) in nsSuiteGlue.js is not run initially. This wasn't much of a problem previously but now the jsdownloads backend is initialised here among other things. Currently this results in the download names not shown if you open it. Also the progress dialog is not shown. The taskbar is also not intialised.

Workaround: As soon as you open a normal browser window the notification is send and the init code executed.

Not sure what the best solution is. Firefox sends the notification if only a private window is opened but our seession store is more or less different and outdated. Send it with a null window like in Fx also results in the notfication not shown (see Bug 573384) and if we have only a address book or mailnews window the startup code will like fail to show a notification too.

So probably best do move some components out of _onBrowserStartup and into a delayed startup like in Firefox after final-ui-startup is received.

I am not sure if we can fix it for 2.53.1 but if not the workaround should be put into the release notes.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1612725-downloadmanager-253.patch

Works for me but needs some cleanups. Not asking for r+ yet.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1612725-downloadmanager-253-V2.patch

[Approval Request Comment]
Regression caused by (bug #): 888915
User impact if declined: downloads backend not initialized if starting with private window or mail.
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): just some reshuffle. Current start beween first window shown and previous session restore notification. Just a bit earlier and for mail too.

This fixes most of the common use cases. There are still edge cases when you start with the address book. In any case it will work as soon as the first mailpane or a browser window is shown.

Follow up fixes for disabling the download manager till then can come later.

Starting the download manager with non-private is not really needed but makes it clearer.
String changes made by this patch: none

Comment 3

[Ian Neal]

Comment on attachment 9125341 [details] [diff] [review]
1612725-downloadmanager-253-V2.patch

[Triage Comment]
Tested on 2.53.x, works fine for -private and -mail
It doesn't on -addressbook or -edit(or) but I don't think there are currently hooks for them. Either way that can be a followup.
r/a=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc4e61149091
Download Manager should always show the complete downloads list even in private mode. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

Fixed 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b779b5d517a7d281aff9b473349b4a47d37f5a78