1612794 - Flexible spacer shrinking is too aggressive

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Harry Twyford]

Attachment: large_urlbar.png

We are now shrinking the flexible spacers too aggressively to make room for the Urlbar. Attached is a screenshot of the latest Nightly as compared to Verdi's spec.

Dao, you've worked on a number of patches in this area recently. Do you know what specific patch might have regressed this?

Comment 1

[Harry Twyford]

I should clarify that I have a flexible spacer on either side of the Urlbar in the screenshot attached to comment 0.

Comment 2

[Harry Twyford]

Also, maybe related: this line doesn't appear to be working. At the window width in the screenshot above, the flexible spacers are invisible in customize mode. Expanding the window shows them.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Harry, can you run mozregression to find when this broke? Doing so will lead you to the specific patch that might have regressed this. You can follow steps at https://mozilla.github.io/mozregression/. Feel free to reach out to me on Matrix/Slack.

Comment 4

[Harry Twyford]

mozregression showed no issue. I changed my profile and sure enough, this problem went away. It's still an issue on my usual profile but if it's not an issue on anyone else's, then I'll just close this as INVALID. Maybe it's something weird I did in customize mode a while ago that bounced off the new rules?

The issue in comment 2 is unrelated. I filed it as bug 1613044.

Comment 5

[Marco Bonardo [:mak]]

Off-hand I cannot reproduce the problem on Win10. It's like in your profile the spacers were ignored or not really present on the toolbar. Something broken with the toolbar status. If you have more things to try I'm happy to help testing.

Comment 6

[Harry Twyford]

My urlbar-container somehow picked up a few attributes that aren't on the Urlbar in a new profile: width="945", cui-areatype="toolbar", and --toolbarbutton-height:32px. Removing the width attribute fixes the problem. I'll keep looking to see what might've added these attributes. This bug isn't about flexible spacers anymore so I'm going to close it as INVALID. I'll file a new bug if I can figure out what caused this issue.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Harry Twyford [:harry] from comment #6)

My urlbar-container somehow picked up a few attributes that aren't on the Urlbar in a new profile: width="945",

It sounds like at some point you had the search bar in the toolbar and manually resized the address bar.

Comment 8

[Itiel]

Attachment: Screenshot

fwiw this happened to me as well since a few days ago.
I didn't resize/changed anything in the toolbar in the last months. I have the searchbar enabled though.