1612941 - (sw-wr-feb) Software WebRender February Milestone

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P1)

Comment 1

[Lee Salzman [:lsalzman]]

The main blocker to getting sw-wr into the tree right now is that glsl-to-cxx fails in mach vendor rust. It seems that both glsl and lexical-core hit the large file limits. glsl might be workable if we submit an upstream PR to split some tests out into a separate file and get below the large file limit. lexical-core we would just have to pull in with permission from a build peer as-is I think. One other downstream library is missing a license which we might need to get fixed... glsl is also BSD-3-clause which will require being added to the whitelist in mach vendor rust... So, overall, the current state of things in that regard is a mess.

Comment 2

[Lee Salzman [:lsalzman]]

Ideally it would also be nice if we could find some way of automagically determining which shader/feature permutations WR is using so that we don't have to generate this by hand, as it's the last barrier to having a build system for swgl that avoids almost all manual intervention for adding or changing shaders in WR.

Comment 3

[Lee Salzman [:lsalzman]]

Otherwise, the secondary blocker for getting swgl integrated into the tree is needing a saner integration with the compositor API, which will both be better for performance as well as require cleaning up instantiation of swgl contexts...

Comment 4

[Jeff Muizelaar [:jrmuizel]]

(In reply to Lee Salzman [:lsalzman] from comment #1)

The main blocker to getting sw-wr into the tree right now is that glsl-to-cxx fails in mach vendor rust. It seems that both glsl and lexical-core hit the large file limits. glsl might be workable if we submit an upstream PR to split some tests out into a separate file and get below the large file limit. lexical-core we would just have to pull in with permission from a build peer as-is I think. One other downstream library is missing a license which we might need to get fixed... glsl is also BSD-3-clause which will require being added to the whitelist in mach vendor rust... So, overall, the current state of things in that regard is a mess.

I just checked and glsl is buildable without lexical-core. I'll submit a PR upstream.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

https://github.com/phaazon/glsl/pull/113

Comment 6

[Lee Salzman [:lsalzman]]

Co-opting this bug to handle the actual landing of sw-wr into Gecko and de-meta-ifying it for now.

Comment 7

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - add deinit hook to WR Compositor trait. r?gw

Comment 8

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - add SWGL glue to webrender_bindings. r?jrmuizel

Depends on D65591

Comment 9

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - add SWGL glue to wrench. r?jrmuizel

Depends on D65592

Comment 10

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - make WR report shader name and features in output for interop with SWGL. r?jrmuizel

Depends on D65593

Comment 11

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - properly detect GL_ARB_texture_swizzle extension in WR. r?gw

Depends on D65595

Comment 12

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - only upload partial GPU cache rows in WR when possible to minimize memory churn. r?gw

Depends on D65596

Comment 13

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - support variable depth buffer size in WR. r?gw

Comment 14

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - add deinit hook to WR Compositor trait. r?gw

Comment 15

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - force immediate upload method for SWGL since PBOs are slower there. r?jrmuizel

Depends on D65602

Comment 16

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - WR shader changes to support SWGL instance attribs. r?jrmuizel

Depends on D65613

Comment 17

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - update gleam version to allow implementation of Gl trait. r?jrmuizel

Depends on D65614

Comment 18

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - import glsl-to-cxx and swgl into Gecko tree. r?jrmuizel

Depends on D65615

Comment 19

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - vendor SWGL's rust dependencies. r?froydnj

Depends on D65616

Comment 20

[Lee Salzman [:lsalzman]]

Try looks pretty green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4aa643ffb850bcc61f3091d8758be0b4779d9ee

Everything is gated by the gfx.webrender.software pref (disabled by default), which enables SWGL if WebRender is also enabled. At least for now, this should prevent SWGL from breaking anything by default.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87ddcdfc5fcf
add deinit hook to WR Compositor trait. r=gw
https://hg.mozilla.org/integration/autoland/rev/c198dedeaa1b
add SWGL glue to webrender_bindings. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/419105739e53
add SWGL glue to wrench. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/54ec5a6e8e45
make WR report shader name and features in output for interop with SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/bd8ba66dc2ac
properly detect GL_ARB_texture_swizzle extension in WR. r=gw,kvark
https://hg.mozilla.org/integration/autoland/rev/375896f494ae
only upload partial GPU cache rows in WR when possible to minimize memory churn. r=gw
https://hg.mozilla.org/integration/autoland/rev/76f80dce8875
support variable depth buffer size in WR. r=gw
https://hg.mozilla.org/integration/autoland/rev/30b28118362a
force immediate upload method for SWGL since PBOs are slower there. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ad7f43d72b08
WR shader changes to support SWGL instance attribs. r=jrmuizel,gw
https://hg.mozilla.org/integration/autoland/rev/9b1360daa75a
update gleam version to allow implementation of Gl trait. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/d92e03315f8d
import glsl-to-cxx and swgl into Gecko tree. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/29f9f745ff65
vendor SWGL's rust dependencies. r=froydnj

Comment 22

[Stefan Hindli [:stefan_hindli]]

Backed out 12 changesets (Bug 1612941) for causing bustages CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=597d165cd5d3f66bb9b68d9adc7b8f4d6777d3de&selectedJob=292666160

https://treeherder.mozilla.org/logviewer.html#?job_id=292666160&repo=autoland

Comment 23

[Lee Salzman [:lsalzman]]

Attachment: Bug 1612941 - update WR Cargo.lock. r?gw

Comment 24

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b8df9d39a0f
Backed out 12 changesets for causing bustages CLOSED TREE

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60151122db4d
add deinit hook to WR Compositor trait. r=gw
https://hg.mozilla.org/integration/autoland/rev/67bba000daba
add SWGL glue to webrender_bindings. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f94d5c7cee41
add SWGL glue to wrench. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/edfca5676513
make WR report shader name and features in output for interop with SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/3cae17a5ec80
properly detect GL_ARB_texture_swizzle extension in WR. r=gw,kvark
https://hg.mozilla.org/integration/autoland/rev/dd1a92041bb4
only upload partial GPU cache rows in WR when possible to minimize memory churn. r=gw
https://hg.mozilla.org/integration/autoland/rev/2d6f65fe6ec0
support variable depth buffer size in WR. r=gw
https://hg.mozilla.org/integration/autoland/rev/ec0fffd12dec
force immediate upload method for SWGL since PBOs are slower there. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/2e0c9b9bd507
WR shader changes to support SWGL instance attribs. r=jrmuizel,gw
https://hg.mozilla.org/integration/autoland/rev/c02c4c5bf7f7
update gleam version to allow implementation of Gl trait. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cd798d2a0433
import glsl-to-cxx and swgl into Gecko tree. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/bbb8ec38f354
vendor SWGL's rust dependencies. r=froydnj

Comment 26

[Stefan Hindli [:stefan_hindli]]

Backed out 12 changesets (Bug 1612941) for webrender linting bustage CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=2883af6562be0036caa8364ef37536e86f08c0b9&selectedJob=292668780

https://treeherder.mozilla.org/logviewer.html#?job_id=292668780&repo=autoland

Comment 27

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/005382a5a58f
Backed out 12 changesets for webrender linting bustage CLOSED TREE

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdf468af2e58
add deinit hook to WR Compositor trait. r=gw
https://hg.mozilla.org/integration/autoland/rev/4bcb997ff4e8
add SWGL glue to webrender_bindings. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/3c5eddbc74b6
add SWGL glue to wrench. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/558806ca7691
make WR report shader name and features in output for interop with SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5097c1d4e3d7
properly detect GL_ARB_texture_swizzle extension in WR. r=gw,kvark
https://hg.mozilla.org/integration/autoland/rev/a85061249e46
only upload partial GPU cache rows in WR when possible to minimize memory churn. r=gw
https://hg.mozilla.org/integration/autoland/rev/b6ea5a6b0a72
support variable depth buffer size in WR. r=gw
https://hg.mozilla.org/integration/autoland/rev/39adb08e0aca
force immediate upload method for SWGL since PBOs are slower there. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/cf730c4e6539
WR shader changes to support SWGL instance attribs. r=jrmuizel,gw
https://hg.mozilla.org/integration/autoland/rev/46024d1d85b3
update gleam version to allow implementation of Gl trait. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f5ed9e999341
import glsl-to-cxx and swgl into Gecko tree. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/08e87bebb606
vendor SWGL's rust dependencies. r=froydnj

Comment 29

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/bdf468af2e58
https://hg.mozilla.org/mozilla-central/rev/4bcb997ff4e8
https://hg.mozilla.org/mozilla-central/rev/3c5eddbc74b6
https://hg.mozilla.org/mozilla-central/rev/558806ca7691
https://hg.mozilla.org/mozilla-central/rev/5097c1d4e3d7
https://hg.mozilla.org/mozilla-central/rev/a85061249e46
https://hg.mozilla.org/mozilla-central/rev/b6ea5a6b0a72
https://hg.mozilla.org/mozilla-central/rev/39adb08e0aca
https://hg.mozilla.org/mozilla-central/rev/cf730c4e6539
https://hg.mozilla.org/mozilla-central/rev/46024d1d85b3
https://hg.mozilla.org/mozilla-central/rev/f5ed9e999341
https://hg.mozilla.org/mozilla-central/rev/08e87bebb606