1612965 - Remove unused netmonitor.ws.time.format

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task, P3)

Description

[:Harald Kirschner :digitarald]

Follow up from bug 1612621.

Comment 1

[Uday Mewada]

I would like to work on it.

Comment 2

[Uday Mewada]

Hi Harald! I searched for the above bug and found that ' netmonitor.ws.time.format ' is found in two files.

* devtools/client/locales/en-US/netmonitor.properties
* dentools/client/netmonitor/src/components/websockets/FrameListColumntime.js

In the first one defined the format in which "netmonitor.ws.time.format" is storing the time.

netmonitor.ws.time.format=%1$S.%2$S

In the second file

formatTime(highResTimeStamp) {
    const timeStamp = Math.floor(highResTimeStamp / 1000);
    const hoursMinutesSeconds = dateTimeFormat.format(new Date(timeStamp));
    return L10N.getFormatStr(
      "netmonitor.ws.time.format",
      hoursMinutesSeconds,
      String(timeStamp % 1000).padStart(3, "0")
    );
  }

I guess above methodformatTime() taking highResTimeStamp as parameter which is in milliseconds. So it converts first into seconds and so on.
Do you have any recommendations to where I can start looking for solving it?

Comment 3

[:Harald Kirschner :digitarald]

Hi Uday,

the second code path was removed in bug 1612621 (just landed yesterday, probably after you checked out mc), only the l10n file is left: https://searchfox.org/mozilla-central/search?q=netmonitor.ws.time.format&case=false&regexp=false&path=

Comment 4

[Uday Mewada]

Attachment: Bug 1612965 - Removed unused 'netmonitor.ws.time.format'.

Comment 5

[Uday Mewada]

sir, I thought this bug is resolved but still showing assigned to me!

Comment 6

[:Harald Kirschner :digitarald]

I just out the patch into the queue for landing. You can do this yourself as well via phabricator, see: https://moz-conduit.readthedocs.io/en/latest/walkthrough.html#landing-the-changes

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07950851001a
Removed unused 'netmonitor.ws.time.format'. r=Harald

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/07950851001a