1612988 - Wrench fails compiling peek-poke with rustc 1.41

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Chris Manchester (limited bugmail, email directly)]

As in https://treeherder.mozilla.org/#/jobs?repo=try&revision=be4ec95aa384b64008f01b04ddf7abcc8dbd25c2&selectedJob=287354044 :

[task 2020-02-03T19:48:55.510Z] error: unnecessary parentheses around type
[task 2020-02-03T19:48:55.510Z]   --> peek-poke/tests/max_size.rs:55:17
[task 2020-02-03T19:48:55.511Z]    |
[task 2020-02-03T19:48:55.511Z] 55 |     assert_eq!(<(isize)>::max_size(), size_of::<isize>());
[task 2020-02-03T19:48:55.511Z]    |                 ^^^^^^^ help: remove these parentheses
[task 2020-02-03T19:48:55.511Z]    |
[task 2020-02-03T19:48:55.511Z]    = note: `-D unused-parens` implied by `-D warnings`
[task 2020-02-03T19:48:55.511Z] 
[task 2020-02-03T19:48:55.643Z] error: aborting due to previous error
[task 2020-02-03T19:48:55.644Z] 
[task 2020-02-03T19:48:55.648Z] error: could not compile `peek-poke`.
[task 2020-02-03T19:48:55.648Z] 
[task 2020-02-03T19:48:55.648Z] Caused by:
[task 2020-02-03T19:48:55.648Z]   process didn't exit successfully: `rustc --edition=2018 --crate-name max_size peek-poke/tests/max_size.rs --error-format=json --json=diagnostic-rendered-ansi --emit=dep-info,link -C debuginfo=2 --test --cfg 'feature="default"' --cfg 'feature="derive"' --cfg 'feature="euclid"' --cfg 'feature="extras"' --cfg 'feature="peek-poke-derive"' -C metadata=58f62cf33974f440 -C extra-filename=-58f62cf33974f440 --out-dir /builds/worker/checkouts/gecko/gfx/wr/target/debug/deps -C incremental=/builds/worker/checkouts/gecko/gfx/wr/target/debug/incremental -L dependency=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps --extern euclid=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libeuclid-694e2540b78da76e.rlib --extern peek_poke=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libpeek_poke-5741aa5ab94552e3.rlib --extern peek_poke_derive=/builds/worker/checkouts/gecko/gfx/wr/target/debug/deps/libpeek_poke_derive-c4c5720d5c236f49.so --deny warnings` (exit code: 1)
[task 2020-02-03T19:48:55.648Z] warning: build failed, waiting for other jobs to finish...
[task 2020-02-03T19:49:09.595Z] error: build failed

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1612988 - Fix warning in a peek_poke test. r=gankro

The test is meant to check that tupes work and a tuple of a single element needs a comma to differentiate it from just being the element.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f020ddf90621
Fix warning in a peek_poke test. r=jrmuizel

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out changeset f020ddf90621 (Bug 1612988) for causing webrender bustage CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=ff37d731d5aa6358f0ca211d5c69096a9f71bf0c&selectedJob=287608245

https://treeherder.mozilla.org/logviewer.html#?job_id=287608245&repo=autoland

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23091d9bdbcd
Backed out changeset f020ddf90621 for causing webrender bustage CLOSED TREE

Comment 5

[Jeff Muizelaar [:jrmuizel]]

[task 2020-02-05T15:49:26.183Z] ./peek-poke/tests/max_size.rs:55: missing space after ,

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6e26b09dcfc
Fix warning in a peek_poke test. r=jrmuizel

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a6e26b09dcfc