1613081 - Enable browser_webconsole_network_messages_openinnet.js for Fission

Status: NEW

(DevTools :: Console, task, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Even when setting the target switching pref (which will be done in 1613035), the test is still failing.
From what I can see, when selecting the "Open in netmonitor" entry in the context menu, we do navigate to the netmonitor, but there the list is empty.

I tried to reproduce outside of the test but couldn't, so maybe this is a timing related issue.

browser_webconsole_network_messages_resend_request suffers seems to suffer from the same problem.

Comment 1

[Alexandre Poirot [:ochameau]]

Note that the netmonitor most likely requires some work in order to work in the content toolbox with fission being turned on.
Noone looked at it yet, so its current behavior is 100% unknown.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly (M6) milestone

Comment 3

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 4

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

this is still failing. Probably the same cause as https://bugzilla.mozilla.org/show_bug.cgi?id=1601331#c21

Comment 6

[Chris Peterson [:cpeterson]]

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Comment 7

[Julian Descottes [:jdescottes]]

I tested this with the patches from https://bugzilla.mozilla.org/show_bug.cgi?id=1644397 but it doesn't fix the issue.

The main reason is that the network events that the test uses are emitted before the new target is available to the client.
Those are typically navigation events (initial document load), but I suppose some other early network requests could fall into the same issue?

This can be an issue both when the resource-watcher cache is involved (eg when netmonitor was not initialized yet) but also without the cache.

Cache scenario

The sequence of events is as follows:

• network event for document load is emitted
• resource-watcher adds the resource to the cache
  (- the resource gets incorrectly (?) linked to the previous target)
• target is created and emitted to the client
• target-list attaches the thread, emits the new target
• resource watcher receives the new top level target, clears the cache

Note that in this case, the async nature of onTargetAvailable is not the cause of the issue. Those network events are extremely early, they arrive before the browsing context target actor is even created.

No-cache scenario

If the netmonitor is already loaded, the cache will not be part of the problem, but the issue is very similar.
The sequence is now:

• network event for document load is emitted
• resource-watcher emits the resource
• netmonitor displays the request
• target is created and emitted to the client
• target-list attaches the thread, emits the new target
• netmonitor receives the new top level target, triggers onWillNavigate which purge old requests

will-navigate issue?

It seems like both cleaning the resource watcher cache & purging old requests should be performed really on will-navigate and not after that (already discussed in Bug 1632141).

Comment 8

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp test and infrastructure bugs for Fission M8 (blocking Release experiment).

Comment 9

[Chris Peterson [:cpeterson]]

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Comment 10

[Alexandre Poirot [:ochameau]]

This test still fails intermittently (pass locally run solo, fails on try):
https://treeherder.mozilla.org/jobs?repo=try&author=apoirot%40mozilla.com&selectedTaskRun=Oxkl62UbRMKoFl_fb8pu4A.0

I suspect this is similar to bug 1601331 comment 27.

Comment 11

[Alexandre Poirot [:ochameau]]

Note that the fail-if rule against this test will be removed in bug 1702715.