Closed Bug 1601331 Opened 5 years ago Closed 3 years ago

Intermittent devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js | Test timed out -

Categories

(DevTools :: Console, defect, P5)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(Fission Milestone:Future)

Status:
RESOLVED INCOMPLETE
Project Flags:
Fission Milestone Future

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file)

Bug 1601331 - Disable browser_webconsole_network_reset_filter.js on fission for frequent failures. r=nchevobbe
47 bytes, text/x-phabricator-request
Details | Review

Filed by: ccoroiu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=279574228&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Vl7iP446QDCE3vOQTeq7Gg/runs/0/artifacts/public/logs/live_backing.log

[task 2019-12-04T15:05:28.431Z] 15:05:28 INFO - TEST-START | devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
[task 2019-12-04T15:09:15.325Z] 15:09:15 INFO - TEST-INFO | started process screentopng
[task 2019-12-04T15:09:15.850Z] 15:09:15 INFO - TEST-INFO | screentopng: exit 0
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages logged at 15:05:28
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Entering test bound
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages logged at 15:05:29
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Adding a new tab with URL: data:text/html;charset=utf8,<p>test file URI
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages logged at 15:05:33
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Tab added and finished loading
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Opening the toolbox
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages logged at 15:05:42
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages logged at 15:05:53
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages logged at 15:05:54
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Toolbox opened and focused
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Wait for document to load
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages logged at 15:06:01
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Matched a message with text: "test-network.html", still waiting for 2 messages.
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - Buffered messages finished
[task 2019-12-04T15:09:15.853Z] 15:09:15 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js | Test timed out -
[task 2019-12-04T15:09:18.157Z] 15:09:18 INFO - Removing tab.
[task 2019-12-04T15:09:18.160Z] 15:09:18 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-12-04T15:09:18.655Z] 15:09:18 INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-12-04T15:09:18.727Z] 15:09:18 INFO - GECKO(1145) | console.warn: "IGNORED REDUX ACTION:" ({type:"AUTOCOMPLETE_CLEAR"})
[task 2019-12-04T15:09:19.146Z] 15:09:19 INFO - GECKO(1145) | JavaScript error: resource://devtools/server/actors/highlighters.js, line 767: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIXPCComponents_Utils.isDeadWrapper]
[task 2019-12-04T15:09:19.150Z] 15:09:19 INFO - Tab removed and finished closing

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE

There are 23 failures associated to this bug in the last 7 days. These are occurring on linux1804-64 (debug and opt builds) and windows10-64 opt.

recent log: https://treeherder.mozilla.org/logviewer.html#?job_id=291233955&repo=mozilla-central

Whiteboard: [stockwell needswork]

Looking at the logs and the failing screenshot (https://firefoxci.taskcluster-artifacts.net/Vs6dwsnPT2W52MGWjCmOjw/0/public/test_info//mozilla-test-fail-screenshot_t9Mgtu.png), it looks like we're missing the network call the the javascript file (https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js#25)

This looks like an issue we have with early resources that we might miss.
What's funny is that we do get the request for the html document, but not for the javascript file linked there.

Alex, did we do anything in context-switching code that would expect the permafail ?

Alexandru, since it's permafailing, it makes sense to skip this test on fission, yes.

Flags: needinfo?(nchevobbe) → needinfo?(poirot.alex)
Assignee: nobody → malexandru
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acebfde0e226
Disable browser_webconsole_network_reset_filter.js on fission for frequent failures. r=nchevobbe
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]

Yes, this is very likely related to network event resource and target switching.

Depends on: 1644191
Flags: needinfo?(poirot.alex)
Whiteboard: [stockwell disabled] → [stockwell disabled] dt-fission-m2-reserve

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Fission Milestone: --- → M7

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Fission Milestone: M7 → MVP
Whiteboard: [stockwell disabled] dt-fission-m2-reserve → [stockwell disabled] dt-fission-m3-mvp

So, enabling server watcher support gets us the expected network events in the console when fission is enabled

diff --git a/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js b/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
--- a/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
+++ b/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
 add_task(async function() {
   await pushPref("devtools.webconsole.filter.net", true);
+  await pushPref("devtools.testing.enableServerWatcherSupport", true);
 
   const toolbox = await openNewTabAndToolbox(TEST_URI, "webconsole");

but the test fails right after when we try to open the network event in the netmonitor, as the netmonitor is completely empty.

Bomsy, is this known that if we start the console first, with network requests displayed, then open the netmonitor, the requests aren't displayed there?

Flags: needinfo?(hmanilla)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #17)

So, enabling server watcher support gets us the expected network events in the console when fission is enabled

diff --git a/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js b/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
--- a/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
+++ b/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
 add_task(async function() {
   await pushPref("devtools.webconsole.filter.net", true);
+  await pushPref("devtools.testing.enableServerWatcherSupport", true);
 
   const toolbox = await openNewTabAndToolbox(TEST_URI, "webconsole");

but the test fails right after when we try to open the network event in the netmonitor, as the netmonitor is completely empty.

Bomsy, is this known that if we start the console first, with network requests displayed, then open the netmonitor, the requests aren't displayed there?

Hmm, i can't seem to replicate this issue. I'm trying on the latest MC. Also the test does not fail for me even with this diff. Am i missing something?

Flags: needinfo?(hmanilla) → needinfo?(nchevobbe)

(In reply to Hubert Boma Manilla (:bomsy) from comment #18)

Hmm, i can't seem to replicate this issue. I'm trying on the latest MC. Also the test does not fail for me even with this diff. Am i missing something?

Do you run it with --enable-fission ? You might need to remove the skip-if line too https://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser/_webconsole.ini#295

Flags: needinfo?(nchevobbe)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #19)

(In reply to Hubert Boma Manilla (:bomsy) from comment #18)

Hmm, i can't seem to replicate this issue. I'm trying on the latest MC. Also the test does not fail for me even with this diff. Am i missing something?

Do you run it with --enable-fission ? You might need to remove the skip-if line too https://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser/_webconsole.ini#295

Ok thanks! I see now when i run the test, but can't replicate it manually. Looking into a fix. Thanks

So, enabling server watcher support gets us the expected network events in the console when fission is enabled

diff --git a/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js b/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
--- a/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
+++ b/devtools/client/webconsole/test/browser/browser_webconsole_network_reset_filter.js
 add_task(async function() {
   await pushPref("devtools.webconsole.filter.net", true);
+  await pushPref("devtools.testing.enableServerWatcherSupport", true);
 
   const toolbox = await openNewTabAndToolbox(TEST_URI, "webconsole");

but the test fails right after when we try to open the network event in the netmonitor, as the netmonitor is completely empty.

Bomsy, is this known that if we start the console first, with network requests displayed, then open the netmonitor, the requests aren't displayed there?

Did some investigations and talked to Alex this looks like a known target switching issue. In my particular tested example it happens when we switch from a data target e.g url is data:text/html ... to a http target e.g url is http://example.com ... but does happen between http://foo.com and http://bar.com for example. For details see Bug 1644397

Depends on: 1644397
Status: REOPENED → ASSIGNED
Assignee: malexandru → nobody
Status: ASSIGNED → NEW

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Fission Milestone: MVP → M7

See https://bugzilla.mozilla.org/show_bug.cgi?id=1613081#c7, Bug 1644397 will not immediately fix this. The issue is that those requests are fired too early, before the JSWindowActor for the new target were created. We need to figure out a way to bring back some will-navigate magic to DevTools fission.

Tracking dt-fission-m3-mvp test and infrastructure bugs for Fission M8 (blocking Release experiment).

Fission Milestone: M7 → M8

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Fission Milestone: M8 → MVP

This test still isn't fixed with my last set of patches which are about to land today.

But bug 1698891, i.e. the enabling of server side target switching and JSWindowActor based targets seems to fix this test (as well as many a couple of other netmonitor tests, like browser_webconsole_shows_reqs_from_netmonitor.js).

Fission Milestone: MVP → Future
Whiteboard: [stockwell disabled] dt-fission-m3-mvp → [stockwell disabled] dt-fission-m4-mvp
Whiteboard: [stockwell disabled] dt-fission-m4-mvp → [stockwell disabled]

This test was re-enabled for Fission in bug 1727325. Closing this bug as incomplete because there have been no reports of this test failure since then.

Status: NEW → RESOLVED
Closed: 5 years ago → 3 years ago
Depends on: 1727325
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: