1613094 - The parameter 'aStartPos' should use const reference.

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P5)

Description

[Kousuke Takaki]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

The other day I submitted patches (Bug 1602088), and Reviewbot said:

"Warning: The parameter 'aStartPos' is copied for each invocation but only used as a const reference; consider making it a const reference [clang-tidy: performance-unnecessary-value-param] Checker reliability is high, meaning that the false positive ratio is low."

I opened a new bug because this issue is not related to Bug 1602088.

As Reviewbot says, the parameter 'aStartPos' should use const reference.

Bug 1602088: https://bugzilla.mozilla.org/show_bug.cgi?id=1602088
Reviewbot: https://phabricator.services.mozilla.com/D61140#1863383

Comment 1

[Botond Ballo [:botond]]

Thank you for filing!

You're welcome to write a patch for it if you'd like, or we can let it be a good first bug for another contributor.

Comment 2

[Kousuke Takaki]

I'll do it right away.

Comment 3

[Kousuke Takaki]

Attachment: Bug 1613094 - The parameter 'aStartPos' should use const reference. r=botond

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9714f4b0af4
The parameter 'aStartPos' should use const reference. r=botond

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e9714f4b0af4