1613181 - "Use proxy for all protocols" should not copy to SOCKS. (port bug 1610423 to Thunderbird)

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect, P3)

Description

[Outvi V]

+++ This bug was initially created as a clone of Bug #969282 +++

When using the setting "use this proxy for all protocols", putting in the IP/port of a SOCKS proxy doesn't work, even though the proxy details are copied to the SOCKS field.

Which is to be expected, because this pref is actually for the HTTP/HTTPS/FTP protocols. A SOCKS proxy accepts all connections, so putting it with stuff it would override doesn't make much sense. Besides, while HTTP proxies can deal with HTTPS and FTP in a fashion, I have yet to see a proxy that can accept HTTP as well as SOCKS connections.

So the copying of the HTTP proxy details into the disabled SOCKS field is a bit misleading since it isn't used. Perhaps the field should be disabled and made empty?

Comment 1

[Richard Marti (:Paenglab)]

We have already ported bug 969282 in bug 1606679 (TB 73). And I have a patch for porting bug 1610423.

I'll use this bug for the port and then try a combined patch for TB 68.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1613181-no-grey-socks-when-proxy-sharing.patch

The patch from bug 1610423 which I port here has r+. I found that I missed to increment in MailMigrator.jsm the version check.

I looked at the possibility for TB 68. The problem is, that there are string changes and migration code. And this migration code makes it as we get issues with the versioning. So I don't think we can port this to 68.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9124852 [details] [diff] [review]
1613181-no-grey-socks-when-proxy-sharing.patch

Review of attachment 9124852 [details] [diff] [review]:
-----------------------------------------------------------------

Thx Richard! r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/33e611ec3605
Port bug 1610423: Stop graying out socks settings when sharing http/ftp/tls proxy settings. r=mkmelin