1613256 - VariableLengthPrefixSet.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1613255 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/VariableLengthPrefixSet.cpp#48

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Sam Zeter]

I'm a newbie and would like to get to know the workflow. Could I take this bug?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure, just propose a patch :)

Comment 3

[Sam Zeter]

Attachment: Bug 1613256 - Refactor EnsureSorted to use std::isSorted r=sg

Comment 4

[Sam Zeter]

If I'm looking at helping out in the future, is the process to express interest on the bug page and then submit a patch (like what I have done) in order to avoid two people submitting the same fix? Or are patches submitted, more commonly, without expressions of interest?

Comment 5

[Simon Giesecke [:sg] [he/him]]

Samuel, that's great to hear :)

It makes sense to assign the bug to yourself once you start working on it. In your case, it got automatically assigned to you once you submitted the patch. That's also fine, but indeed increases the risk you mentioned :) With more complex bugs, it makes sense to assign it to yourself and first discuss what you plan to do by commenting on the bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd65ac107627
Refactor EnsureSorted to use std::isSorted  r=sg

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bd65ac107627