1613257 - InspectorUtils.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1613255 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/layout/inspector/InspectorUtils.cpp#471

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Adnan Rahman Chowdhury]

I've never worked on any Firefox bug before. I'd like to work on this bug and start contributing to Firefox.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Sure, please submit a patch!

Comment 3

[tds803]

hey! new contributor! I was wondering how I would go about testing this? (or if it even needs to be tested?)

Comment 4

[tds803]

Attachment: Bug 1613257 removed redundant return statement. r=smaug

redundant return statment for GetCSSValuesForProperty in InseoectorUtils.cpp removed

Comment 5

[Adnan Rahman Chowdhury]

Hi! Looks like the solution is already ready. I'm too new - I was just going through phabricator and other documentation to submit a patch.

Is it true that the solution is ready?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Yeah, you can have a look to https://bugzilla.mozilla.org/show_bug.cgi?id=1613255

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Moving to a tiny bit better component.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/893b0327c644
removed redundant return statement. r=smaug

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/893b0327c644