InspectorUtils.cpp: redundant return statement at the end of a function with a void return type
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: tds803, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1613255 +++
Filling as a good first bug to learn workflows.
return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/layout/inspector/InspectorUtils.cpp#471
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
|
||
Comment 1•5 years ago
|
||
I've never worked on any Firefox bug before. I'd like to work on this bug and start contributing to Firefox.
hey! new contributor! I was wondering how I would go about testing this? (or if it even needs to be tested?)
redundant return statment for GetCSSValuesForProperty in InseoectorUtils.cpp removed
|
||
Updated•5 years ago
|
|
|
||
Comment 5•5 years ago
|
||
Hi! Looks like the solution is already ready. I'm too new - I was just going through phabricator and other documentation to submit a patch.
Is it true that the solution is ready?
|
Reporter | |
Comment 6•5 years ago
|
||
Yeah, you can have a look to https://bugzilla.mozilla.org/show_bug.cgi?id=1613255
|
||
Comment 7•5 years ago
|
||
Moving to a tiny bit better component.
|
|
||
Updated•5 years ago
|
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/893b0327c644 removed redundant return statement. r=smaug
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
Description
•