Closed Bug 1613257 Opened 2 months ago Closed 2 months ago

InspectorUtils.cpp: redundant return statement at the end of a function with a void return type

Categories

(Core :: CSS Parsing and Computation, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: Sylvestre, Assigned: tds803, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1613255 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/layout/inspector/InspectorUtils.cpp#471

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

I've never worked on any Firefox bug before. I'd like to work on this bug and start contributing to Firefox.

Sure, please submit a patch!

hey! new contributor! I was wondering how I would go about testing this? (or if it even needs to be tested?)

redundant return statment for GetCSSValuesForProperty in InseoectorUtils.cpp removed

Assignee: nobody → tds803
Attachment #9124945 - Attachment description: Bug 1613257 removed redundant return statment → Bug 1613257 removed redundant return statment. r=smaug
Status: NEW → ASSIGNED

Hi! Looks like the solution is already ready. I'm too new - I was just going through phabricator and other documentation to submit a patch.

Is it true that the solution is ready?

Moving to a tiny bit better component.

Component: Source Code Analysis → CSS Parsing and Computation
Product: Firefox Build System → Core
Attachment #9124945 - Attachment description: Bug 1613257 removed redundant return statment. r=smaug → Bug 1613257 removed redundant return statement. r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/893b0327c644
removed redundant return statement. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.