1613264 - Double clicking to select the text in the urlbar doesn't work for some completions anymore

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

STR:

• Type "goo"
• This will autocomplete to "google.com" and will suggest "https://google.com/ -- Visit"
• Double clicking in the urlbar should select all the text but it doesn't. It selects it momentarily and then unselects it.

I did a regression window and found this:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b9ffa67dd4dfb935b4f39010eefd615c6d70fdab&tochange=32f7019f65826f9aab0d36d177064461ed1f9b40

Comment 1

[Jeff Muizelaar [:jrmuizel]]

[Tracking Requested - why for this release]: A user noticeable regression

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Thanks, on focus we open the view and re-run the query, when the query completes we end up resetting the selection and that causes the problem. I'll look into solutions for this.

Comment 3

[Alexandra Martin]

Tested on Windows 10 x64 and Mac 10.14 and only Nightly 74.0a1 (2020-02-04) is affected by the issue. Therefore, will add the according flags.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It's not just double clicking, even single clicking to move the cursor is broken if the result was autofilled. It's because we used to not requery if the view was open, but tab switch wants to requery regardless. In Bug 1601052 I took the tab switch path and forgot the bring back the isOpen check for the other path.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1613264 - Clicking on urlbar text is misbehaving on autofill. r=adw

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b6868dfc7a7
Clicking on urlbar text is misbehaving on autofill. r=adw

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for leaks at (AbstractThread, AbstractWatcher, AnimationTimeline, AsyncFreeSnowWhite).

Backout link: https://hg.mozilla.org/integration/autoland/rev/034b35b48e8d71b0cb157f500d05490ca0753e47
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287705214&repo=autoland&lineNumber=12857

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

That looks really suspicious, this is a trivial ui change, are you sure it's related to this push?

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I guess it must be related to storing the TabSelect event...

Comment 10

[Narcis Beleuzu [:NarcisB]]

:mak , the failures started with this push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C10.14%2Cdebug&fromchange=c02a7a545a87e7d519dc8d36113ee05afcd8bde3&tochange=30d70d402f129680a93490db6898d933013b67b3

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Thanks, I'll check on Try if it's the event caching.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5d555a9991a
Clicking on urlbar text is misbehaving on autofill. r=adw

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e5d555a9991a