Closed Bug 1613490 Opened 6 years ago Closed 6 years ago

Cleanup TransformReferenceBox usage to avoid calling Width() and Height() when not needed.

Categories

(Core :: Web Painting, defect)

Product:
Core
Component:
Web Painting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1613490 - Cleanup usage of ReferenceBox. r=boris,miko
47 bytes, text/x-phabricator-request
Details | Review

We call it way more than what we should.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

To avoid computing transform bounds over and over. It is generally just better.

Replace the various "overridebounds" thingies by using the "fallback" of the
transform-reference-box code which we need anyway.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd533d780ee7 Cleanup usage of ReferenceBox. r=miko

https://hg.mozilla.org/mozilla-central/rev/bd533d780ee7

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Regressions: 1626840
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: