1626840 - Graphical clipping/tearing on right edge of the screen

Status: VERIFIED FIXED

(Core :: Web Painting, defect)

Description

[patlo]

Attachment: Screen Shot 2020-04-02 at 1.27.29 AM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15

Steps to reproduce:

See https://miniature.to/home/
Visuals are created in CSS. 3D transform (rotate/translate) or overflow might be the cupid.

Actual results:

Graphics on right edge is clipped/teared off.

Expected results:

See Firefox 73 (or earlier) or other browsers for how it should look properly.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Alice0775 White]

I can reproduce the issue on Nightly76.0a1 Windows10 with/without WebRender and safe mode.

When mouse drag to the right hand side or zoom by clicking (+) icon,

*without WebRender or safe mode:
wall paper, staircase, door, woman, potted plant, furniture and label are truncated

*with WebRender:
woman, potted plant and label are truncated

Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8e3be55481b952ed17d24c1d50f5f59b9996e480&tochange=bd533d780ee7970ac5590fb7f4247e197e621733

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: reduced

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(The reduced test-case works in WR, but displays nothing in non-WR. I suspect it's the same underlying issue though).

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1626840 - Use the right reference box for preserve-3d children. r=miko

Clearly WPT doesn't have enough preserve3d tests :(

This was being used by the overflow computation, which computed a too-tight
overflow, and thus clipped too much. Test fails without the patch as expected.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9137713 [details]
Bug 1626840 - Use the right reference box for preserve-3d children. r=miko

Beta/Release Uplift Approval Request

• User impact if declined: Pages with 3d content may get wrong clipping.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): one-line change + test
• String changes made/needed: none

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d29e079a13eb
Use the right reference box for preserve-3d children. r=miko

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22651 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d29e079a13eb

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9137713 [details]
Bug 1626840 - Use the right reference box for preserve-3d children. r=miko

Approving for 75.0rc2 on Julien's behalf.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/6326a42b8310

Comment 13

[Alin Ilea, Desktop QA]

Reproduced the initial issue in release version 74 using Windows 10.
Verified - Fixed in latest Nightly 76.0a1 (2020-04-03) and 75.0rc2 (build id: 20200403043714) using Windows 10 and Ubuntu 18.04.

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot