1613608 - Enable Interventions in Nightly

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Harry Twyford]

+++ This bug was initially created as a clone of Bug #1606910 +++

Product gave us the okay to enable Interventions in Nightly.

Comment 1

[Harry Twyford]

Try run on top of bug 1613603 with Interventions enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e0d2faad707fd18216737a50922d1d151fefb4e

Comment 2

[Harry Twyford]

Attachment: Bug 1613608 - Enable Interventions in Nightly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d619690c640b
Enable Interventions in Nightly. r=mak

Comment 4

[Oana Pop-Rus]

Backed out changeset d619690c640b (bug 1613608) for xpcshell failures in test_UrlbarQueryContext_restrictSource.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C10.14%2Cdebug%2Cxpcshell%2Ctests%2Ctest-macosx1014-64%2Fdebug-xpcshell-e10s-2%2Cx%28x2%29&fromchange=365e6997c2986df2cb5da89b22404ee00c1bbd70&selectedJob=287745991

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287745991&repo=autoland&lineNumber=4713
and https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287748880&repo=autoland&lineNumber=2305

Backout: https://hg.mozilla.org/integration/autoland/rev/014b0d94c202656bc3394e46780c0c1fcf9d031a

Comment 5

[Harry Twyford]

Drew, do you know what's happening here? This is related to the work in bug 1606918. The failure logs aren't very helpful, but running the tests locally it seems to be that the unit tests can't perform the update check because the XPCOM getter on the updateManager doesn't work. Here are the first few frames from a local failure:

Unexpected Results
------------------
FAIL browser/components/urlbar/tests/unit/test_UrlbarQueryContext_restrictSource.js - xpcshell return code: 0
ERROR Unexpected exception NS_ERROR_XPC_GS_RETURNED_FAILURE: ServiceManager::GetService returned failure code:
XPCU_serviceLambda@resource://gre/modules/XPCOMUtils.jsm:215:30
get@resource://gre/modules/XPCOMUtils.jsm:129:51
get isPending@resource:///modules/AppUpdater.jsm:107:1
get isReadyForRestart@resource:///modules/AppUpdater.jsm:157:5
check@resource:///modules/AppUpdater.jsm:66:9
checkForBrowserUpdate@resource:///modules/UrlbarProviderInterventions.jsm:641:18
isActive@resource:///modules/UrlbarProviderInterventions.jsm:504:10
start@resource:///modules/UrlbarProvidersManager.jsm:295:20
startQuery@resource:///modules/UrlbarProvidersManager.jsm:194:17
startQuery@resource:///modules/UrlbarController.jsm:133:24
get_results@/Users/harry/Developer/src/artifact/mozilla-central/objdir/_tests/xpcshell/browser/components/urlbar/tests/unit/test_UrlbarQueryContext_restrictSource.js:135:20

Comment 6

[Drew Willcoxon :adw]

I'm not sure, but it's something like the update manager isn't available in an xpcshell environment. The toolkit/mozapps/update tests have xpcshell tests for different parts of update functionality, and there's a giant helper file they import so that they work. Presumably we would need to do the same to mock the update manager, but I'm only guessing. I don't think we should do that.

Can we do something like try-catch creating the manager and returning false from isActive if it failed? We don't need to test the interventions provider from xpcshell.

Comment 7

[Drew Willcoxon :adw]

Attachment: Bug 1613608 - Enable Interventions in Nightly but not in xpcshell tests.

Comment 8

[Drew Willcoxon :adw]

The patch I just posted fixes it for me locally, and the main interventions test still passes.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61b059f65c1d
Enable Interventions in Nightly but not in xpcshell tests. r=harry

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/61b059f65c1d