1613640 - [RTL] A vertical scrollbar is wrongly displayed on the onboarding modal if the "Continue" button is clicked while the email field is empty

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

[Affected versions]:

• Firefox 74.0a1 Build ID 20200205215017

[Affected Platforms]:

• Windows 10
• Mac 10.14
• Linux Ubuntu 16.04

[Prerequisites]:

• Use a RTL Firefox Nightly build.

[Steps to reproduce]:

1. Open about:welcome page.
2. Click the “Continue” button.

[Expected result]:
“Enter email” field is highlighted in red and the "Valid email required" message is displayed.

[Actual result]:
A vertical scrollbar is also displayed in the left part of the onboarding modal.

[Additional notes]:

• Issue is also reproducible if invalid values are typed in the e-mail field.
• On Mac OS an horizontal scrollbar is also displayed for a few seconds.
• Issue is not reproducible using LTR builds

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1613640 - Removed unneeded scrollbar in RTL display for about:welcome & editTopSites

Comment 2

[Tim Spurway [:tspurway]]

[Tracking Requested - why for this release]: User facing bug in onboarding

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a70c847dc6c
Removed unneeded scrollbar in RTL display for about:welcome & editTopSites r=pdahiya

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a70c847dc6c

Comment 5

[Valentina Virlics [:vvalentina], Ecosystem QA]

I have verified that the issue is no longer reproducible on Firefox Nightly 75.0a1 Build ID 20200212205745 on Windows 10, Mac 10.14 and Linux Ubuntu 16.04.
The vertical scrollbar is no longer displayed after "Continue" button is clicked for an invalid e-mail field using a Firefox RTL build.

Comment 6

[Emily McMinn :emcminn]

Comment on attachment 9125197 [details]
Bug 1613640 - Removed unneeded scrollbar in RTL display for about:welcome & editTopSites

Beta/Release Uplift Approval Request

• User impact if declined: Users using the RTL display will see an extraneous scrollbar on the about:welcome and editTopSites modals.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Navigate to about:welcome and set the page direction to RTL. Click the continue button in the modal while leaving the email fields empty; the "valid email required" error should appear. A scrollbar should no longer appear on the left side of the modal.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS change to scroll: auto only.
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9125197 [details]
Bug 1613640 - Removed unneeded scrollbar in RTL display for about:welcome & editTopSites

Low risk css change for rtl builds, uplift approved for 74.0b5, thanks.

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c80293c156e

Comment 9

[Valentina Virlics [:vvalentina], Ecosystem QA]

I have verified that the issue is no longer reproducible on Firefox Beta 74.0b5 Build ID 20200218224219 on Windows 10, Mac 10.14 and Linux Ubuntu 16.04.
The vertical scrollbar is no longer displayed after "Continue" button is clicked for an invalid e-mail field using a Firefox RTL build.