1613855 - Set separate limits for the redirect and onboarding Search Tips

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Harry Twyford]

Currently, we show Search Tips a total of four times. This isn’t good: users whose workflow is to open a new tab then go to google.com will only ever see the about:newtab Search Tip. Also, if we decide to add a new kind of Search Tip in the future, many users won’t see it because we’ve already shown them their alloted four Tips. We should set separate maximum counts for both kinds of Search Tips. That is, showing the about:newtab Search Tip up to 4 times and the search engine homepage Tip up to 4 times. Users should still only ever see at most one Search Tip of any kind in any one session. Engaging with one kind of Search Tip should permanently disable that kind of Tip, but not the other kind.

Comment 1

[Marco Bonardo [:mak]]

I was planning to work on this in bug 1608461, as yesterday I asked whether someone was planning to work on it :)
Anyway, if you're close to have a patch I'm happy to work on top of it.

Comment 2

[Harry Twyford]

Attachment: Bug 1613855 - Set separate limits for the redirect and onboarding Search Tips. r?mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b407a1a33d6
Set separate limits for the redirect and onboarding Search Tips. r=mak

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1b407a1a33d6