1614656 - Search Tips shownCount prefs are set incorrectly

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Harry Twyford]

Bug 1613855 erroneously sets the prefs searchTips.(type).shownCount rather than browser.urlbar.searchTips.(type).shownCount, meaning that shownCount will not be meaningfully recorded. This should be corrected and uplifted to beta.

Comment 1

[Harry Twyford]

Attachment: Bug 1614656 - Set Search Tips shownCount prefs correctly. r?adw!

Comment 2

[Harry Twyford]

I should point out that the correct pref is set to MAX_SHOWN_COUNT when the user engages with Search Tips, so this is not a case of there being no way to permanently dismiss them. The bug is that a user can ignore Search Tips an unlimited number of times and they will continue to show. Still something we should fix and uplift ASAP.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57223bd1c4c6
Set Search Tips shownCount prefs correctly. r=adw

Comment 4

[Marco Bonardo [:mak]]

Does this mean we have no automated test checking the count is increased properly?
It may be be worth adding one in a follow-up.

Comment 5

[Harry Twyford]

We point out that we don't test that feature because it would require a restart. That said, we could use the pref in bug 1614651 to disable the showedTipInCurrentSession flag and test that the count is increasing.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/57223bd1c4c6

Comment 7

[Harry Twyford]

Comment on attachment 9125826 [details]
Bug 1614656 - Set Search Tips shownCount prefs correctly. r?adw!

Beta/Release Uplift Approval Request

• User impact if declined: Annoying behaviour with the Urlbar's new Search Tips feature: the user can ignore them any number of times and they will continue appearing once per session. Note the user would still be able to permanently dismiss them by interacting with the Search Tip.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: It's easiest to first import the patch currently up for review at https://phabricator.services.mozilla.com/D62437, or to wait for it to land. That will add a hidden pref browser.urlbar.searchTips.test.disableChecks that will make Search Tips appear every time a new tab or the user's default search engine homepage is opened.

Once that patch is included:
0. Open Firefox with a fresh profile and set the hidden pref browser.urlbar.searchTips.test.disableChecks to true.

1. Observe the prefs browser.urlbar.searchTips.onboard.shownCount and browser.urlbar.searchTips.redirect.shownCount do not exist.
2. Open about:newtab. Observe that a Search Tip is shown in the Urlbar.
3. Observe that the pref browser.urlbar.searchTips.onboard.shownCount now has a value of 1.
4. Ensure the default search engine is Google and open google.com. Observe that a Search Tip is shown in the Urlbar.
5. Observe that the pref browser.urlbar.searchTips.redirect.shownCount now has a value of 1.

• List of other uplifts needed: Bug 1615276
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch changes the name of a pref being recorded from searchTips.onboard.shownCount and searchTips.redirect.shownCount to browser.urlbar.searchTips.onboard.shownCount and browser.urlbar.searchTips.redirect.shownCount. Worst case is that this patch sets the wrong pref name again and we're in the same place we were in without this patch.

It's covered by an automated test, added in bug 1615276, which I've requested be uplifted as well.

• String changes made/needed:

Comment 8

[Harry Twyford]

I've landed the hidden pref mentioned in the STR. It's bug 1614651 and should be in Nightly soon. The final pref name is browser.urlbar.searchTips.test.ignoreShowLimits.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9125826 [details]
Bug 1614656 - Set Search Tips shownCount prefs correctly. r?adw!

Visible UX bug on a new feature, uplift approved for 74?0b5, thanks.

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7d5877892b1e

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We have to postpone verifying this issue to early next week due to the lack of context on "Search Tips" and the fact that Search Tips is now blocking the QuantumBar Design 1 release.
I am going to needinfo myself as a reminder.

Comment 12

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm the fix.
I verified using Fx 74.0b7, Fx 75.0a1, on Windows 10 x64, macOS 10.15 and Ubuntu 18.04.