1613899 - dom/base/test/test_bug976673.html fails with Fission focus code

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Henri Sivonen (:hsivonen)]

Re-enable dom/base/test/test_bug976673.html for Fission. (Filing ahead of landing the regressing bug in order to mint a bug number.)

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission mochitests (M4.1)

nsFocusManager::SetFocus bug 1556627 regressed and disabled this test for Fission, so we now need to fix and re-enable it.

Comment 2

[Henri Sivonen (:hsivonen)]

This bug may or may not actually depend on bug 1614297 or bug 1615548, but those are the ones that have the most direct repro mechanics, so it doesn't make sense to pursue this one before those are fixed.

Comment 3

[Henri Sivonen (:hsivonen)]

Still fails with the patches for the blockers of bug 1618135.

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1613899 - Re-enable test_bug976673.html for Fission.

Comment 5

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef439a9f9dcea76a571201fa6017ce40384f78a0

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hsivonen, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bef822368a0
Re-enable test_bug976673.html for Fission. r=masayuki

Comment 9

[Alexandru Michis [:malexandru]]

Backed out changeset 8bef822368a0 for causing failures in test_bug976673.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/7ff4febab0297d1eacb54e19e851f822b73357ce

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-mochitest-plain-fis-e10s-16%2Cm-fis%2816%29&fromchange=b8a583d8b972c7cab3f6103cc9fa113463ebd43c&tochange=7ff4febab0297d1eacb54e19e851f822b73357ce&selectedTaskRun=RKrfgD5JTomD2sZZVzKG6Q-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301736246&repo=autoland&lineNumber=5466

Comment 10

[Henri Sivonen (:hsivonen)]

Sigh. The changes in the bug that this depended on made this no longer work. I'll come back to this after some more work has landed.

Comment 11

[Henri Sivonen (:hsivonen)]

New try run with patch for bug 1634363:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=10848823565110127b497802b5ee373eaad32227

Comment 12

[Henri Sivonen (:hsivonen)]

Still fails. Upon further reading of the test, it could depend on bug 1613054.

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Chris, I think we should move the Fission milestone to M6c per the dependency.

Comment 14

[Chris Peterson [:cpeterson]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #13)

Hi Chris, I think we should move the Fission milestone to M6c per the dependency.

Sounds good. Thanks for updating the bug milestone.

Comment 15

[Henri Sivonen (:hsivonen)]

Bug 1613054 part 2 seems to fix the test failure.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5cabeca6aa7
Re-enable test_bug976673.html for Fission. r=masayuki

Comment 17

[Henri Sivonen (:hsivonen)]

Re-landed bug 1613054, which should make it possible not to back out this one.

Comment 18

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c5cabeca6aa7