Closed Bug 1614147 Opened 4 months ago Closed 4 months ago

CTSerialization.cpp: unused variable 'kTreeSizeLength'

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: Sylvestre, Assigned: zech.ph, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1614139 +++

Filling as a good first bug to learn workflows.

unused variable 'kTreeSizeLength':
https://searchfox.org/mozilla-central/source/security/ct/CTSerialization.cpp#42

As the change is trivial, it is just to learn how to contribute to Firefox.

https://clang.llvm.org/docs/DiagnosticsReference.html#wunused-const-variable

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

I came here via up-for-grabs.net looking for some opportunity to contribute. May I take this bug as a first opportunity?

sure!
please provide a patch!

Ok, will do my best! Still cloning the sources though...

done! I specified jcj as reviewer (I did so as of checking the log, r=jcj).

Assignee: nobody → zech.ph
Status: NEW → ASSIGNED
Pushed by jjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cad4ca428d35
remove unused variable 'kTreeSizeLength' r=jcj
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.