1614208 - Remove some dependencies on style system headers from other common headers.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

The ultimate goal here was to not rebuild dom/media when touching the style system.

There's still more work for that to be possible, but here's a start.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Forward-declare StaticPresData in nsPresContext.h. r=jfkthame

This avoids including nsFont.h and a bunch of other stuff in nsPresContext.h

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Remove more dependencies on nsStyleConsts.h / ServoStyleConsts.h. r=jfkthame

Mostly what I was seeing come up in the .deps files from my object directory
which sounded feasible.

Depends on D62166

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Remove unused WritingMode ipdl include. r=jfkthame

Depends on D62167

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Stop including AccessibleCaretEventHub and PresShell.h from Selection.h. r=TYLin

And fix a bunch of fallout as we now don't include nsDocShell.h everywhere.

Depends on D62168

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Stop including PresShell.h and nsPresContext.h from Element.h. r=smaug

nsPresContext.h is only used for unit conversion, which can be done by Units.h
in a similar fashion.

PresShell.h was needed for some capturing-content stuff which can be moved out
of line.

Depends on D62169

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Remove some unneeded ContentCache.h includes. r=masayuki

It can be forward-declared. ContentCache.h includes WritingModes.h which
includes a whole lot of stuff.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Remove nsStyleConsts usage from TextRange.h. r=masayuki

Depends on D62171

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Stop including nsStyleConsts.h from WebRenderTypes.h. r=jrmuizel

This is another one which is included everywhere. If the OOL call mattered we
could move these to a different header or something, but I suspect it won't.

Depends on D62172

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1614208 - Remove some include dependencies in nsStyleConsts.h. r=jfkthame

We include it everywhere because it's included from gfxTypes.h.

This should avoid including all the generated bindings everywhere.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5edfca9532a0
Remove some include dependencies in nsStyleConsts.h. r=jfkthame,jgilbert
https://hg.mozilla.org/integration/autoland/rev/e6157dd5307d
Forward-declare StaticPresData in nsPresContext.h. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/87393dbd95ed
Remove more dependencies on nsStyleConsts.h / ServoStyleConsts.h. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/e9054e5ec42d
Remove unused WritingMode ipdl include. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/fc8778ea318f
Stop including AccessibleCaretEventHub and PresShell.h from Selection.h. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/a281e11c7dac
Stop including PresShell.h and nsPresContext.h from Element.h. r=smaug
https://hg.mozilla.org/integration/autoland/rev/1346808aa42d
Remove nsStyleConsts usage from TextRange.h. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/1800ca8ff653
Stop including nsStyleConsts.h from WebRenderTypes.h. r=jrmuizel

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5edfca9532a0
https://hg.mozilla.org/mozilla-central/rev/e6157dd5307d
https://hg.mozilla.org/mozilla-central/rev/87393dbd95ed
https://hg.mozilla.org/mozilla-central/rev/e9054e5ec42d
https://hg.mozilla.org/mozilla-central/rev/fc8778ea318f
https://hg.mozilla.org/mozilla-central/rev/a281e11c7dac
https://hg.mozilla.org/mozilla-central/rev/1346808aa42d
https://hg.mozilla.org/mozilla-central/rev/1800ca8ff653