Closed
Bug 1615532
Opened 4 years ago
Closed 4 years ago
Forgot to update GeckoEditable.IME_RANGE_LINE* when line style of TextRangeStyle is changed
Categories
(Core Graveyard :: Widget: Android, defect, P1)
Core Graveyard
Widget: Android
Tracking
(firefox-esr68 unaffected, firefox73 unaffected, firefox74 unaffected, firefox75 fixed)
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox73 | --- | unaffected |
| firefox74 | --- | unaffected |
| firefox75 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Regression)
Details
(Keywords: inputmethod, regression)
Attachments
(1 file)
When I review the patch for bug 1614208, I forgot to mention about constants in Java. I'll post a patch which will make it to enum class too.
|
Assignee | |
Comment 1•4 years ago
|
||
Oh, I found another regression of bug 1614208. It does not handle solid line in nsTextFrame.cpp.
|
|
Assignee | |
Comment 2•4 years ago
|
||
At bug 1614208, the line style value mapping was changed, but
GeckoEditable.IME_RANGE_LINE_* are not updated.
This patch makes the style in TextRangeStyle an enum class for making it
type safer, and updates GeckoEditable.IME_RANGE_LINE_*, and finally, adds
FYI comments in TextRangeStyle to make developers realize it requires
manual update.
|
||
Updated•4 years ago
|
status-firefox73:
--- → unaffected
status-firefox74:
--- → unaffected
status-firefox-esr68:
--- → unaffected
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/71842b9975c2 Make line style in TextRangeStyle an enum class and sync it with GeckoEditable.IME_RANGE_LINE_* r=m_kato
|
|
Assignee | |
Updated•4 years ago
|
Summary: Forgot to GeckoEditable.IME_RANGE_LINE* when line style of TextRangeStyle is changed → Forgot to update GeckoEditable.IME_RANGE_LINE* when line style of TextRangeStyle is changed
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•