1615532 - Forgot to update GeckoEditable.IME_RANGE_LINE* when line style of TextRangeStyle is changed

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When I review the patch for bug 1614208, I forgot to mention about constants in Java. I'll post a patch which will make it to enum class too.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, I found another regression of bug 1614208. It does not handle solid line in nsTextFrame.cpp.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1615532 - Make line style in TextRangeStyle an enum class and sync it with GeckoEditable.IME_RANGE_LINE_* r=m_kato!

At bug 1614208, the line style value mapping was changed, but
GeckoEditable.IME_RANGE_LINE_* are not updated.

This patch makes the style in TextRangeStyle an enum class for making it
type safer, and updates GeckoEditable.IME_RANGE_LINE_*, and finally, adds
FYI comments in TextRangeStyle to make developers realize it requires
manual update.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71842b9975c2
Make line style in TextRangeStyle an enum class and sync it with GeckoEditable.IME_RANGE_LINE_* r=m_kato

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/71842b9975c2