1614346 - Create Fission crashtest for Fuzzer dom::Location::CallerSubsumes() Assertion failure: outer, at /builds/worker/workspace/build/src/dom/base/Location.cpp:622

Status: RESOLVED FIXED

(Core :: DOM: Window and Location, defect, P3)

Description

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

Testcase found while fuzzing mozilla-central rev d3aa4a9e4dfd. Testcase must be served over HTTP in order to reproduce.

Assertion failure: outer, at /builds/worker/workspace/build/src/dom/base/Location.cpp:622

==18383==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000001 (pc 0x7f2057e17a12 bp 0x7ffec86d15f0 sp 0x7ffec86d1480 T0)
==18383==The signal is caused by a WRITE memory access.
==18383==Hint: address points to the zero page.
    #0 0x7f2057e17a11 in mozilla::dom::Location::CallerSubsumes(nsIPrincipal*) /builds/worker/workspace/build/src/dom/base/Location.cpp:622:3
    #1 0x7f205843118c in Reload /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Location.h:48:10
    #2 0x7f205843118c in mozilla::dom::Location_Binding::reload(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/build/src/obj-firefox/dom/bindings/LocationBinding.cpp:1141:24
    #3 0x7f2059919195 in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeCrossOriginObjectThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /builds/worker/workspace/build/src/dom/bindings/BindingUtils.cpp:3170:13
    #4 0x7f205fd92dd3 in CallJSNative /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:470:13
    #5 0x7f205fd92dd3 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:562:12
    #6 0x7f205fd94bca in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:625:10
    #7 0x7f205fd796eb in CallFromStack /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:629:10
    #8 0x7f205fd796eb in Interpret(JSContext*, js::RunState&) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:3042:16
    #9 0x7f205fd5cd44 in js::RunScript(JSContext*, js::RunState&) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:442:10
    #10 0x7f205fd92eb5 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:597:13
    #11 0x7f205fd94bca in InternalCall(JSContext*, js::AnyInvokeArgs const&, js::CallReason) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:625:10
    #12 0x7f205fd94ea6 in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:642:8
    #13 0x7f205ff2aca2 in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /builds/worker/workspace/build/src/js/src/jsapi.cpp:2797:10
    #14 0x7f205952e800 in mozilla::dom::EventListener::HandleEvent(JSContext*, JS::Handle<JS::Value>, mozilla::dom::Event&, mozilla::ErrorResult&) /builds/worker/workspace/build/src/obj-firefox/dom/bindings/EventListenerBinding.cpp:52:8
    #15 0x7f2059fd8b0b in void mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>(mozilla::dom::EventTarget* const&, mozilla::dom::Event&, mozilla::ErrorResult&, char const*, mozilla::dom::CallbackObject::ExceptionHandling, JS::Realm*) /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/EventListenerBinding.h:66:12
    #16 0x7f2059fd8544 in mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, mozilla::dom::Event*, mozilla::dom::EventTarget*) /builds/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1073:43
    #17 0x7f2059fd9ba6 in mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event**, mozilla::dom::EventTarget*, nsEventStatus*, bool) /builds/worker/workspace/build/src/dom/events/EventListenerManager.cpp:1271:17
    #18 0x7f2059fc788f in mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) /builds/worker/workspace/build/src/dom/events/EventDispatcher.cpp:356:17
    #19 0x7f2059fc5de1 in mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) /builds/worker/workspace/build/src/dom/events/EventDispatcher.cpp:558:16
    #20 0x7f2059fca89b in mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) /builds/worker/workspace/build/src/dom/events/EventDispatcher.cpp:1055:11
    #21 0x7f205c5bec7e in nsDocumentViewer::LoadComplete(nsresult) /builds/worker/workspace/build/src/layout/base/nsDocumentViewer.cpp:1143:7
    #22 0x7f205f0f59d7 in nsDocShell::EndPageLoad(nsIWebProgress*, nsIChannel*, nsresult) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp:6102:20
    #23 0x7f205f0f4b85 in nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp:5885:7
    #24 0x7f205f0f95ef in non-virtual thunk to nsDocShell::OnStateChange(nsIWebProgress*, nsIRequest*, unsigned int, nsresult) /builds/worker/workspace/build/src/docshell/base/nsDocShell.cpp
    #25 0x7f20567c7630 in nsDocLoader::DoFireOnStateChange(nsIWebProgress*, nsIRequest*, int&, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:1347:3
    #26 0x7f20567c65bc in nsDocLoader::doStopDocumentLoad(nsIRequest*, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:906:14
    #27 0x7f20567c2890 in nsDocLoader::DocLoaderIsEmpty(bool) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:726:9
    #28 0x7f20567c50c3 in nsDocLoader::OnStopRequest(nsIRequest*, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp:614:5
    #29 0x7f20567c614c in non-virtual thunk to nsDocLoader::OnStopRequest(nsIRequest*, nsresult) /builds/worker/workspace/build/src/uriloader/base/nsDocLoader.cpp
    #30 0x7f205407b337 in mozilla::net::nsLoadGroup::NotifyRemovalObservers(nsIRequest*, nsresult) /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp:604:22
    #31 0x7f205407e547 in mozilla::net::nsLoadGroup::RemoveRequest(nsIRequest*, nsISupports*, nsresult) /builds/worker/workspace/build/src/netwerk/base/nsLoadGroup.cpp:511:10
    #32 0x7f2057d4080f in mozilla::dom::Document::DoUnblockOnload() /builds/worker/workspace/build/src/dom/base/Document.cpp:10712:18
    #33 0x7f2057cf655c in mozilla::dom::Document::UnblockOnload(bool) /builds/worker/workspace/build/src/dom/base/Document.cpp:10644:9
    #34 0x7f2057d1b85c in mozilla::dom::Document::DispatchContentLoadedEvents() /builds/worker/workspace/build/src/dom/base/Document.cpp:7312:3
    #35 0x7f2057de67c4 in applyImpl<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/build/src/obj-firefox/dist/include/nsThreadUtils.h:1163:12
    #36 0x7f2057de67c4 in apply<mozilla::dom::Document, void (mozilla::dom::Document::*)()> /builds/worker/workspace/build/src/obj-firefox/dist/include/nsThreadUtils.h:1169:12
    #37 0x7f2057de67c4 in mozilla::detail::RunnableMethodImpl<mozilla::dom::Document*, void (mozilla::dom::Document::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/build/src/obj-firefox/dist/include/nsThreadUtils.h:1215:13
    #38 0x7f2053dbebd3 in mozilla::SchedulerGroup::Runnable::Run() /builds/worker/workspace/build/src/xpcom/threads/SchedulerGroup.cpp:282:20
    #39 0x7f2053df3358 in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/workspace/build/src/xpcom/threads/nsThread.cpp:1220:14
    #40 0x7f2053dfe16c in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/workspace/build/src/xpcom/threads/nsThreadUtils.cpp:486:10
    #41 0x7f205504ff6f in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/workspace/build/src/ipc/glue/MessagePump.cpp:87:21
    #42 0x7f2054f496d7 in RunInternal /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:315:10
    #43 0x7f2054f496d7 in RunHandler /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:308:3
    #44 0x7f2054f496d7 in MessageLoop::Run() /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:290:3
    #45 0x7f205c01ea08 in nsBaseAppShell::Run() /builds/worker/workspace/build/src/widget/nsBaseAppShell.cpp:137:27
    #46 0x7f205fb2cfd6 in XRE_RunAppShell() /builds/worker/workspace/build/src/toolkit/xre/nsEmbedFunctions.cpp:943:20
    #47 0x7f2054f496d7 in RunInternal /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:315:10
    #48 0x7f2054f496d7 in RunHandler /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:308:3
    #49 0x7f2054f496d7 in MessageLoop::Run() /builds/worker/workspace/build/src/ipc/chromium/src/base/message_loop.cc:290:3
    #50 0x7f205fb2c67f in XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/workspace/build/src/toolkit/xre/nsEmbedFunctions.cpp:778:34
    #51 0x55ce20889403 in content_process_main /builds/worker/workspace/build/src/browser/app/../../ipc/contentproc/plugin-container.cpp:56:28
    #52 0x55ce20889403 in main /builds/worker/workspace/build/src/browser/app/nsBrowserApp.cpp:303:18
    #53 0x7f20768cdb96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/build/src/dom/base/Location.cpp:622:3 in mozilla::dom::Location::CallerSubsumes(nsIPrincipal*)

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: prefs.js

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:kmag, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 4

[Bob Clary [:bc] (inactive)]

fyi, bughunter has seen this once on windows and multiple times on linux under asan.

Comment 5

[Jens Stutte [:jstutte]]

Chris, can you please (let) triage this? Thank you!

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Jens Stutte [:jstutte] from comment #5)

Chris, can you please (let) triage this? Thank you!

Sending to Fission triage.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:smaug, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Julien Cristau [:jcristau]]

Same assertion as bug 1614259, so maybe a duplicate?

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Julien Cristau [:jcristau] from comment #8)

Same assertion as bug 1614259, so maybe a duplicate?

This bug is the same assertion failure as bug 1614259, but since we have a reproducible fuzzer test case, we'd like to make the fuzzer test case into a crashtest.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:peterv, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 11

[Chris Peterson [:cpeterson]]

This bug is a Fission Nightly blocker. We'd like to enable more crashtests soon, so tracking for milestone M6b.

Comment 12

[Timothy Nikkel (:tnikkel)]

Does this still happen? The bugs for the same assertions have been marked fixed and I couldn't reproduce.

Comment 13

[Jason Kratzer [:jkratzer]]

:tnikkel, I am unable to reproduce this bug on tip. Bisection appears to point to the following commit

Start: b0e84820d231a3b5a47f2ea72c384828d91f4c49 (20200213024515)
End: b158903288bb2968dff9e587a3a8ca67f7435e37 (20200213030033)
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b0e84820d231a3b5a47f2ea72c384828d91f4c49&tochange=b158903288bb2968dff9e587a3a8ca67f7435e37

Comment 14

[Timothy Nikkel (:tnikkel)]

Let's mark it fixed by that bug.