1614421 - [Linux] Black vertical bar in native-styled select dropdown widget, on Ubuntu 19.10

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot 1 (showing the bug on an empty dropdown widget)

STR:

1. View this data URI:

data:text/html,<select>

ACTUAL RESULTS:
There's an unexpected black vertical bar to the left of the dropdown arrow.

EXPECTED RESULTS:
No such vertical bar.

Screenshot attached. I'm using Ubuntu 19.10 with the default theme (Yaru)

mozregression says this regressed from
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=23091d9bdbcd200e1b535696a5f6d38b41889493&tochange=accd5248459408246d4bf269125120072dbee608
which is bug 1613130.

Comment 1

[Daniel Holbert [:dholbert]]

It looks like that regressing bug's patch made us change to start drawing something (instead of drawing nothing) for missing widget-parts like MOZ_GTK_COMBOBOX_SEPARATOR (which seems to be the widget-part that's involved here).

In this case, the "drawing something" is drawing an awkward-looking black bar.

stransky, would you mind taking a look? Can/should we go back to drawing nothing for this (perhaps-intentionally) unimplemented widget?

Comment 2

[Daniel Holbert [:dholbert]]

[Tracking Requested - why for this release]: visual regression in Firefox 74 (which is the beta version, as of some point this week)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot 2 (showing the bug in a a dropdown widget with actual text content)

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Sure, will look at it.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1614421 [Linux] Use GtkInvisible as a fallback widget, r?jhorak

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbf22b1c04bd
[Linux] Use GtkInvisible as a fallback widget, r=jhorak

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dbf22b1c04bd

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9125760 [details]
Bug 1614421 [Linux] Use GtkInvisible as a fallback widget, r?jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Visual glitch when combobox is rendered on Ubuntu/Yaru theme.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux only theme fix.
• String changes made/needed: none

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9125760 [details]
Bug 1614421 [Linux] Use GtkInvisible as a fallback widget, r?jhorak

Low risk visual fix on Linux, uplift approved for 74.0b3, thanks.

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef73c9a504c0

Comment 13

[Wellington Torrejais da Silva]

Attachment: Screenshot_2020-02-24 Web Forms 2 0 test page.png

Hi,

Still occurring: 75.0a1 (2020-02-24) (64-bit)

Thanks!

Comment 14

[Daniel Holbert [:dholbert]]

Yeah, I'm seeing the white bar shown in comment 13 as well, in current Nightly as well as in Nightly 2020-02-12 (the day after the patch landed). I'm on Ubuntu 19.10 still.

So: it looks like the patch just changed the vertical stripe from black to white, unfortunately. :-/ It's more subtle, but still there. It's too bad we didn't notice this sooner. stransky, should we reopen, or track this in a new bug?

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Let's reopen, I'll attach the patch here.

Comment 16

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1614421 [Linux/Gtk] Don't use a fallback widget when it's missing, r?jhorak

With Bug 1613130 fixed we may not need a fallback widget so let's remove this workaround.

Comment 17

[Pascal Chevrel:pascalc (PTO until April 26)]

Martin, I would prefer a patch and an uplift request in a new bug, thanks.

Comment 18

[Martin Stránský [:stransky] (ni? me)]

okay.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

Filed as Bug 1617858.