1614478 - Disable DOM Presentation API and tests for Fission (so we can remove <iframe mozbrowser>)

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, task, P2)

Description

[Kris Maglione [:kmag]]

<iframe mozbrowser> is being removed, which means that any tests that use it need to either be updated or disabled.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission dogfooding (M5) because rm-mozbrowser bug 1614462 is blocking M5.

Comment 2

[Chris Peterson [:cpeterson]]

Olli, do we have plans to ship the DOM Presentation API in Gecko? The feature was added for B2G, but is disabled by the pref dom.presentation.enabled. On desktop, it's disabled in all channels. On Android, it's enabled in GeckoView Nightly but disabled in Beta and Release.

https://searchfox.org/mozilla-central/rev/96f1457323cc598a36f5701f8e67aedaf97acfcf/modules/libpref/init/StaticPrefList.yaml#2098-2106

Who owns Gecko's DOM Presentation API and tests?

For reference: "Can I use Presentation API?" https://caniuse.com/#feat=mdn-api_presentation

If we don't plan to ship the API in 2020, then this bug to make it Fission-compatible doesn't need to block Fission MVP.

Comment 3

[Chris Peterson [:cpeterson]]

Olli, can we just turn off the Presentation tests when Fission is enabled? This bug is blocking kmag from removing mozbrowser.

Nika says Overholt says no one is currently working on Presentation API.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

snorp might know if we want Presentation API on GV.
(if we want, we should probably rewrite the tests)

Comment 5

[Chris Peterson [:cpeterson]]

So if we do want Presentation API, it would be restricted to mobile for the foreseeable future?

If that is the case, then it won't need to block Fission MVP on desktop.

Comment 6

[Kris Maglione [:kmag]]

To be clear, we'd need to turn the tests off in e10s mode, not just in Fission mode.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

We don't have any presentation API stuff hooked up in GV AFAIK, so it's probably fine to disable/remove that stuff.

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to James Willcox (:snorp) ([e-mail]) (he/him) from comment #7)

We don't have any presentation API stuff hooked up in GV AFAIK, so it's probably fine to disable/remove that stuff.

In that case, we can track disabling or removing the Presentation API for Fission's mochitests milestone (M4.1).

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Is this still blocking something, given that Bug 1614462 is closed? Would it be sufficient to add the following for failing tests?

disabled:
    if (os == "android") and e10s: bug 1614478

Comment 10

[Marcos Caceres [:marcosc]]

I've not personally seen much interest in this API - not sure what drove it to be implemented in the first place? (there might have been a good reason, but I honestly don't know). I think we should disable it for now and maybe bring it back once we have a Product/content strategy for it.

Comment 11

[Chris Peterson [:cpeterson]]

(In reply to Kagami :saschanaz from comment #9)

Is this still blocking something, given that Bug 1614462 is closed? Would it be sufficient to add the following for failing tests?

disabled:
    if (os == "android") and e10s: bug 1614478

SGTM. The Presentation API itself is disabled on desktop and in GeckoView's Beta and Release channels on Android, so making the API or tests compatible with Fission is not a high priority:

https://searchfox.org/mozilla-central/rev/dc4560dcaafd79375b9411fdbbaaebb0a59a93ac/modules/libpref/init/StaticPrefList.yaml#2218-2226

I see there a lot of presentation tests already disabled with skip-if = e10s. For example:

https://searchfox.org/mozilla-central/rev/dc4560dcaafd79375b9411fdbbaaebb0a59a93ac/dom/presentation/tests/mochitest/mochitest.ini#30-41

Since this API was originally added for B2G, I should check whether KaiOS cares about it.

Comment 12

[Chris Peterson [:cpeterson]]

Since this API was originally added for B2G, I should check whether KaiOS cares about it.

KaiOS people say the Presentation API is currently disabled in KaiOS, but they are interested in using it again. We should disable the failing tests and leave the implementation in tree, if feasible.

Comment 13

[Kagami Rosylight [:saschanaz] (they/them)]

I think we have no work item here, as Bug 1614462 already removed mozbrowser support and no test is broken so far. AFAICT tests that use mozbrowser are already disabled, as stated in #c11.

Comment 14

[Chris Peterson [:cpeterson]]

(In reply to Kagami :saschanaz from comment #13)

I think we have no work item here, as Bug 1614462 already removed mozbrowser support and no test is broken so far. AFAICT tests that use mozbrowser are already disabled, as stated in #c11.

In that case, I'll close this bug as WORKSFORME. Thanks for checking!