1614462 - (rm-mozbrowser) Remove support for <iframe mozbrowser> in content

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Description

[Kris Maglione [:kmag]]

Keeping these working is becoming increasingly difficult, especially in light of Fission, and they're not actually available to any production code anymore.

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively assigning to kmag because he said is working on this bug this week.

Tracking for Fission dogfooding (M5)

Comment 2

[Chris Peterson [:cpeterson]]

Removing mozbrowser doesn't strictly block Fission dogfooding, but removing it is a high priority for kmag because it is causing extra work.

Comment 3

[Chris Peterson [:cpeterson]]

Moving P2 M5 bugs to M5b milestone

Comment 4

[Chris Peterson [:cpeterson]]

M6a because not a dogfooding blocker.

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 1 - Remove unused message principals. r=nika

These were added for the sake of app browsers, and all of the code which
actually needed them has since been removed.

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 2a - Remove commented out mozbrowser test code. r=mccr8

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 2b - Remove unnecessary mozbrowser usage in chrome tests. r=mccr8

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 2c - Remove content mozbrowser tests. r=mccr8

<iframe mozbrowser> is no longer supported in content processes.

Comment 9

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8

These tests used <iframe mozbrowser> for convenience, mostly forcing
themselves to only run in non-e10s mode in the process, but none of them
really have any need to.

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 2e - Migrate desktop-only CrashService_crash test to browser test. r=mconley

Comment 11

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 2f - Remove browser-element mochitests. r=mccr8

Comment 12

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 3a - Remove support for <iframe mozbrowser> in content processes. r=nika

Comment 13

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 3b - Remove moribund DocShell FrameType/IsMozBrowser/IsInMozBrowser fields. r=nika

Comment 14

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 3c - Remove dead TabContext IsMozBrowserElement fields. r=nika

Comment 15

[Kris Maglione [:kmag]]

Attachment: Bug 1614462: Part 3d - Remove unused BrowserElementChild scripts. r=nika

The only remaining mozbrowser consumer is Responsive Design Mode, which
doesn't rely on any of its content JS APIs.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7deaed376ed
Part 1 - Remove unused message principals. r=nika
https://hg.mozilla.org/integration/autoland/rev/b4819c99e16e
Part 2a - Remove commented out mozbrowser test code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/6d2137eb1d52
Part 2b - Remove unnecessary mozbrowser usage in chrome tests. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/90ed81cbfe34
Part 2c - Remove content mozbrowser tests. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0ffed1dc4296
Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e4ad5037658f
Part 2e - Migrate desktop-only CrashService_crash test to browser test. r=mconley
https://hg.mozilla.org/integration/autoland/rev/cd6b8d630f4c
Part 2f - Remove browser-element mochitests. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/512bbab4730c
Part 3a - Remove support for <iframe mozbrowser> in content processes. r=nika
https://hg.mozilla.org/integration/autoland/rev/dbc2e2556d08
Part 3b - Remove moribund DocShell FrameType/IsMozBrowser/IsInMozBrowser fields. r=nika
https://hg.mozilla.org/integration/autoland/rev/34d4a86530b4
Part 3c - Remove dead TabContext IsMozBrowserElement fields. r=nika

Comment 17

[Andrei Ciure[:aciure]]

Backed out 10 changesets (bug 1614462) for causing xpcshell failures
https://hg.mozilla.org/integration/autoland/rev/e122301f3d12cc7f6f7ab6802957d946d0d39b79

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298007694&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=34d4a86530b425cc3adf17751431864949a68f4d&searchStr=xpc

failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=298007694&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=298007356&repo=autoland

Comment 18

[Andreea Pavel [:apavel]]

Also caused https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298007359&repo=autoland&lineNumber=6519

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cf4898ae08d
Part 1 - Remove unused message principals. r=nika
https://hg.mozilla.org/integration/autoland/rev/93b3bacdbb34
Part 2a - Remove commented out mozbrowser test code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e68c38a7741d
Part 2b - Remove unnecessary mozbrowser usage in chrome tests. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/2106f3ccc4b5
Part 2c - Remove content mozbrowser tests. r=mccr8,marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ecc3477ed34e
Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a73ef8167cd4
Part 2e - Migrate desktop-only CrashService_crash test to browser test. r=mconley
https://hg.mozilla.org/integration/autoland/rev/7f604ee5731c
Part 2f - Remove browser-element mochitests. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/284002de7137
Part 3a - Remove support for <iframe mozbrowser> in content processes. r=nika
https://hg.mozilla.org/integration/autoland/rev/c61b797d63e9
Part 3b - Remove moribund DocShell FrameType/IsMozBrowser/IsInMozBrowser fields. r=nika
https://hg.mozilla.org/integration/autoland/rev/bf4f8253c708
Part 3c - Remove dead TabContext IsMozBrowserElement fields. r=nika

Comment 20

[Andrei Ciure[:aciure]]

Backed out 10 changesets (bug 1614462) for causing test_ipc_messagemanager_blob.js failures
https://hg.mozilla.org/integration/autoland/rev/f352804ccc8d6fb3969b3fb719f6dfb608cbd0c0

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-android-em-7.0-x86_64%2Fdebug-geckoview-xpcshell-e10s-1%2Cx%28x1%29&fromchange=190c19f63256d035a5aa9396e40135cd44e7abe2&tochange=f352804ccc8d6fb3969b3fb719f6dfb608cbd0c0&selectedJob=298509239

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298501454&repo=autoland

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1671f0fdf34
Part 1 - Remove unused message principals. r=nika
https://hg.mozilla.org/integration/autoland/rev/59cc469c0fe5
Part 2a - Remove commented out mozbrowser test code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/68361305d05b
Part 2b - Remove unnecessary mozbrowser usage in chrome tests. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5dbc1ee8dc91
Part 2c - Remove content mozbrowser tests. r=mccr8,marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/b8b4460b4aed
Part 2d - Fix tests that don't need to use mozbrowser. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/32fb3428fd5f
Part 2e - Migrate desktop-only CrashService_crash test to browser test. r=mconley
https://hg.mozilla.org/integration/autoland/rev/b6e41de98857
Part 2f - Remove browser-element mochitests. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/d3cf0a8b0472
Part 3a - Remove support for <iframe mozbrowser> in content processes. r=nika
https://hg.mozilla.org/integration/autoland/rev/3c37d27ef0af
Part 3b - Remove moribund DocShell FrameType/IsMozBrowser/IsInMozBrowser fields. r=nika
https://hg.mozilla.org/integration/autoland/rev/f5526af32dfe
Part 3c - Remove dead TabContext IsMozBrowserElement fields. r=nika

Comment 22

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a1671f0fdf34
https://hg.mozilla.org/mozilla-central/rev/59cc469c0fe5
https://hg.mozilla.org/mozilla-central/rev/68361305d05b
https://hg.mozilla.org/mozilla-central/rev/5dbc1ee8dc91
https://hg.mozilla.org/mozilla-central/rev/b8b4460b4aed
https://hg.mozilla.org/mozilla-central/rev/32fb3428fd5f
https://hg.mozilla.org/mozilla-central/rev/b6e41de98857
https://hg.mozilla.org/mozilla-central/rev/d3cf0a8b0472
https://hg.mozilla.org/mozilla-central/rev/3c37d27ef0af
https://hg.mozilla.org/mozilla-central/rev/f5526af32dfe