1614494 - Remove <iframe mozbrowser> usage in devtools server tests

Status: RESOLVED FIXED

(DevTools :: General, task, P2)

Description

[Kris Maglione [:kmag]]

<iframe mozbrowser> is being removed, which means that any tests that use it need to either be updated or disabled.

Comment 1

[Patrick Brosset <:pbro>]

Here are the tests that I think need to be changed:

• https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/devtools/server/tests/chrome/test_connectToFrame.html#40-43
• https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/devtools/server/tests/chrome/test_getProcess.html#71-77
• https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/devtools/server/tests/chrome/test_setupInParentChild.html#39-42
• https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html#49-51

Related, RDM also uses <iframe mozbrowser> and the dependency removal is tracked in bug 1574886.

Comment 2

[Patrick Brosset <:pbro>]

Replace the remote iframes in those tests with something like this should work according to Alex:

b = document.createElementNS("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul","browser"); b.setAttribute("type", "content");

Comment 3

[Kris Maglione [:kmag]]

(In reply to Patrick Brosset <:pbro> from comment #1)

Related, RDM also uses <iframe mozbrowser> and the dependency removal is tracked in bug 1574886.

Note that RDM usage isn't a problem for bug 1614462, since it happens in the parent process, and that bug is only removing usage in child processes.

(In reply to Patrick Brosset <:pbro> from comment #2)

Replace the remote iframes in those tests with something like this should work according to Alex:

b = document.createElementNS("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul","browser"); b.setAttribute("type", "content");

Assuming that the tests run in the parent process, I think it should. Though in that case, it also shouldn't block bug 1614462, since I'm not removing mozbrowser support in parent process chrome documents until RDM is fixed. But it would still probably be best to get them updated as soon as possible in case we run into more <mozbrowser> issues that need more aggressive changes sooner.

Comment 4

[Alexandre Poirot [:ochameau]]

(In reply to Patrick Brosset <:pbro> from comment #2)

Replace the remote iframes in those tests with something like this should work according to Alex:

b = document.createElementNS("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul","browser"); b.setAttribute("type", "content");

Unfortunately, this snippet, which works in the browser console, doesn't work in these tests as the chrome mochitests run within a browser tab and so within a <browser type=content>. This brings many limitations.
So. It would be easier to migrate them to browser mochitest while switching to <browser>.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1614494 - Migrate connectToFrame to browser mochitest and use <browser> element.

Comment 6

[Alexandre Poirot [:ochameau]]

Here is one test, I'll convert the others similarly after having a review of the first.

Comment 7

[Chris Peterson [:cpeterson]]

Tracking for Fission dogfooding (M5) because rm-mozbrowser bug 1614462 is blocking M5.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c15166aa140
Migrate connectToFrame to browser mochitest and use <browser> element. r=pbro,jdescottes

Comment 9

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d4b35d68e2afdceef2efe2d273bba9d203a954b

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1614494 - Refactor all DevTools test using mozbrowser iframes.

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4c15166aa140

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00d7c55bd88e
Refactor all DevTools test using mozbrowser iframes. r=jdescottes

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/00d7c55bd88e