1614504 - Remove blank lines from profile before passing it to browsertime

Status: RESOLVED FIXED

(Testing :: Performance, defect, P1)

Description

[Greg Mierzwinski [:sparky]]

This bug is to remove blank lines from the profile before passing it to browsertime with --firefox.profileTemplate.

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1614504 - Remove blank lines from profile before passing it to browsertime. r?#perftest

Comment 2

[Greg Mierzwinski [:sparky]]

Error that we get when the profile has blank lines in it:

20:28:23     INFO -  1581366502851	geckodriver::capabilities	DEBUG	Creating profile directory tree /tmp/rust_mozprofileqlA4OO/extensions/
20:28:23     INFO -  1581366502851	geckodriver::capabilities	DEBUG	Extracting profile to /tmp/rust_mozprofileqlA4OO/pkcs11.txt
20:28:23     INFO -  1581366502851	geckodriver::capabilities	DEBUG	Extracting profile to /tmp/rust_mozprofileqlA4OO/prefs.js
20:28:23     INFO -  1581366502851	geckodriver::capabilities	DEBUG	Extracting profile to /tmp/rust_mozprofileqlA4OO/user.js
20:28:23     INFO -  1581366502851	geckodriver::capabilities	DEBUG	Extracting profile to /tmp/rust_mozprofileqlA4OO/extensions/[e-mail]
20:28:23     INFO -  1581366502851	geckodriver::capabilities	DEBUG	Extracting profile to /tmp/rust_mozprofileqlA4OO/cert9.db
20:28:23     INFO -  1581366502851	geckodriver::capabilities	DEBUG	Extracting profile to /tmp/rust_mozprofileqlA4OO/key4.db
20:28:23     INFO -  1581366502853	mozdevice	WARN	adb server response contained hexstring length 99 and message length was 99 and message was "ZY322HN2H9             device usb:1-2 product:cedric model:Moto_G__5_ device:cedric transport_id:9\n"
20:28:23     INFO -  1581366502853	geckodriver::android	DEBUG	Android port forward (33875 -> 2829) started
20:28:23    ERROR -  thread 'webdriver dispatcher' panicked at 'index out of bounds: the len is 9140 but the index is 18446744073709551615', testing/mozbase/rust/mozprofile/src/prefreader.rs:291:38
20:28:23     INFO -  stack backtrace:
20:28:23     INFO -     0:     0x5650ddb5db6b - backtrace::backtrace::libunwind::trace::hfe5db90796807973
20:28:23     INFO -                                 at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/libunwind.rs:88
20:28:23     INFO -     1:     0x5650ddb5db6b - backtrace::backtrace::trace_unsynchronized::h34b865a835594335
20:28:23     INFO -                                 at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/mod.rs:66
20:28:23     INFO -     2:     0x5650ddb5db6b - std::sys_common::backtrace::_print::h527254ae44989167
20:28:23     INFO -                                 at src/libstd/sys_common/backtrace.rs:47
20:28:23     INFO -     3:     0x5650ddb5db6b - std::sys_common::backtrace::print::he85dd5ddddf46503
20:28:23     INFO -                                 at src/libstd/sys_common/backtrace.rs:36
20:28:23     INFO -     4:     0x5650ddb5db6b - std::panicking::default_hook::{{closure}}::h847a2eb38b396f14
20:28:23     INFO -                                 at src/libstd/panicking.rs:200
20:28:23     INFO -     5:     0x5650ddb5d847 - std::panicking::default_hook::h2ca0f9a30a0e206b
20:28:23     INFO -                                 at src/libstd/panicking.rs:214
20:28:23     INFO -     6:     0x5650ddb5e2e0 - std::panicking::rust_panic_with_hook::hffcefc09751839d1
20:28:23     INFO -                                 at src/libstd/panicking.rs:477
20:28:23     INFO -     7:     0x5650ddb5de62 - std::panicking::continue_panic_fmt::hc0f142c930c846fc
20:28:23     INFO -                                 at src/libstd/panicking.rs:384
20:28:23     INFO -     8:     0x5650ddb5dd46 - rust_begin_unwind
20:28:23     INFO -                                 at src/libstd/panicking.rs:311
20:28:23     INFO -     9:     0x5650ddb7efed - core::panicking::panic_fmt::h2daf88b2616ca2b2
20:28:23     INFO -                                 at src/libcore/panicking.rs:85
20:28:23     INFO -    10:     0x5650ddb7efa5 - core::panicking::panic_bounds_check::h0537ade040df571e
20:28:23     INFO -                                 at src/libcore/panicking.rs:61
20:28:23     INFO -    11:     0x5650dda04e69 - <mozprofile::prefreader::PrefTokenizer as core::iter::traits::iterator::Iterator>::next::h034b25f8c77aa86a
20:28:23     INFO -    12:     0x5650dda050c2 - mozprofile::prefreader::parse_tokens::hd06997b5e398d0c2
20:28:23     INFO -    13:     0x5650dda07740 - mozprofile::profile::PrefFile::new::h50be22e46d685384
20:28:23     INFO -    14:     0x5650dda071c2 - mozprofile::profile::Profile::user_prefs::h1711dfc51c96be9d
20:28:23     INFO -    15:     0x5650dd9be37f - geckodriver::marionette::MarionetteHandler::set_prefs::h488655b2d37eee1d
20:28:23     INFO -    16:     0x5650dd9ba563 - geckodriver::marionette::MarionetteHandler::start_android::h3e7917d706f9cbf2
20:28:23     INFO -    17:     0x5650dd9b40c0 - geckodriver::marionette::MarionetteHandler::create_connection::h6974fde7b2fb8502
20:28:23     INFO -    18:     0x5650dd9bf0e1 - <geckodriver::marionette::MarionetteHandler as webdriver::server::WebDriverHandler<geckodriver::command::GeckoExtensionRoute>>::handle_command::hecd2c7e22ecb19ec
20:28:23     INFO -    19:     0x5650dd93265b - std::sys_common::backtrace::__rust_begin_short_backtrace::h9672f6f9b166aa26
20:28:23     INFO -    20:     0x5650dd938f56 - std::panicking::try::do_call::h1f4100a35f25aba4
20:28:23     INFO -  [2020-02-10 15:28:23] INFO: [browsertime] Browser failed to start, trying 0 more time(s): ECONNREFUSED connect ECONNREFUSED 127.0.0.1:54258
20:28:23     INFO -  [2020-02-10 15:28:23] ERROR: [browsertime] BrowserError: Could not start the browser with 3 tries

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cbc0e036bdd
Remove blank lines from profile before passing it to browsertime. r=perftest-reviewers,octavian_negru

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3cbc0e036bdd