Closed Bug 161453 Opened 22 years ago Closed 17 years ago

Remove XP_MAC from typelib/xpidl

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: philor)

References

Details

Attachments

(1 file, 2 obsolete files)

Fix
2.57 KB, patch
timeless
: review+
mrbkap
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review 
cw7.2, it's only used in a #else /*#ifdef XP_MAC*/

    
  
Keywords: patch

    
    

    
  
Comment on attachment 94309 [details] [diff] [review]
wrap buffer_size in #else/*#ifdef XP_MAC*/

r=dbradley

Hopefully this submit doesn't crash

        Attachment #94309 -
        Flags: review+

    
  
Status: NEW → ASSIGNED

    
  
Target Milestone: --- → mozilla1.4alpha

    
    

    
  
Moving out
Target Milestone: mozilla1.4alpha → mozilla1.5alpha

    
    

    
  
I'm morphing this bug into remove the XP_MAC code from xpidl since its no longer
needed.
Summary: xpidl_idl.c buffer_size is unused → Remove XP_MAC from typelib/xpidl

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Removes XP_MAC code (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #94309 -
        Attachment is obsolete: true

    
  
Target Milestone: mozilla1.5alpha → mozilla1.5beta

    
    

    
  
Moving out, speak up if you believe this needs to be considered for 1.5b
Target Milestone: mozilla1.5beta → mozilla1.6alpha

    
    

    
  
This bug is targeted at a Mac classic platform/OS, which is no longer supported
by mozilla.org. Please re-target it to another platform/OS if this bug applies
there as well or resolve this bug.

I will resolve this bug as WONTFIX in four weeks if no action has been taken.
To filter this and similar messages out, please filter for "mac_cla_reorg".

    
    

    
  
this bug should stay open, as it is meant for removing mac classic specific code.

    
    

    
  
Biesi, you're right, but shouldn't we better target this bug to All/All?
OS: Mac System 9.x → All
Hardware: Macintosh → All

    
    

    
  
Moving out
Target Milestone: mozilla1.6alpha → mozilla1.7alpha

    
  
Assignee: dbradley → nobody
Status: ASSIGNED → NEW
QA Contact: pschwartau → xpidl
Target Milestone: mozilla1.7alpha → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix
        — 
          — Splinter Review
      

    


  
Assignee: nobody → philringnalda

        Attachment #127175 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #285572 -
        Flags: review?(timeless)

    
  

        Attachment #285572 -
        Flags: review?(timeless) → review+

    
  

        Attachment #285572 -
        Flags: superreview?(mrbkap)

        Attachment #285572 -
        Flags: superreview?(mrbkap) → superreview+

    
  

        Attachment #285572 -
        Flags: approval1.9?

    
    

    
  
Comment on attachment 285572 [details] [diff] [review]
Fix

a=release drivers

        Attachment #285572 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
xpcom/typelib/xpt/tests/SimpleTypeLib.c 1.25
xpcom/typelib/xpidl/xpidl.h 1.49
xpcom/typelib/xpidl/xpidl_util.c 1.27
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED

    
  
Component: xpidl → XPCOM
QA Contact: xpidl → xpcom

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: