280247 - Remove XP_MAC from xpcom

Status: RESOLVED DUPLICATE of bug 281889

(Core :: XPCOM, defect)

Description

[Ludovic Hirlimann [:Usul]]

Cleaning bug. We only build Mach-O these days. This bug is to clean up CFM code

Comment 1

[Ludovic Hirlimann [:Usul]]

Attachment: remove XP_MAC from xpcom/base

Patch removing XP_MAC in xpcom/base.
other directories within xpcom will follow.

Comment 2

[Ludovic Hirlimann [:Usul]]

Attachment: remove XP_MAC from xpcom/components

xpcom/components

Comment 3

[Ludovic Hirlimann [:Usul]]

Attachment: remove XP_MAC from xpcom/ds

remove from ds, asking review to darin so dougt doesn't have all the patches to
review.

Comment 4

[Ludovic Hirlimann [:Usul]]

Attachment: remove XP_MAC from xpcom/io

asking darin for xpcom/io.
file nsLocalFileMac.h can be removed

Comment 5

[Ludovic Hirlimann [:Usul]]

Attachment: remove XP_MAC from xpcom/reflect/xptcall

files in xpcom/reflect/xptcall/src/md/mac can be removed

Comment 6

[Ludovic Hirlimann [:Usul]]

Attachment: remove XP_MAC from xpcom/typelib/xpidl

Comment 7

[Ludovic Hirlimann [:Usul]]

I think I got them all.

Comment 8

[Darin Fisher]

Comment on attachment 172738 [details] [diff] [review]
remove XP_MAC from xpcom/ds

>Index: nsTimelineService.cpp

> static PRTime Now(void)
> {
>     return PR_Now();
> }

It would seem that you could just replace all instances of Now()
with PR_Now() and then eliminate Now().


r=darin with that change

Comment 9

[Darin Fisher]

Comment on attachment 172743 [details] [diff] [review]
remove XP_MAC from xpcom/io

I think that nsLocalFileMac.{h,cpp} could also be CVS removed.

r=darin

Comment 10

[Darin Fisher]

Comment on attachment 172818 [details] [diff] [review]
remove XP_MAC from xpcom/typelib/xpidl

r=darin

Comment 11

[Darin Fisher]

I think you should get someone like Simon Fraser or Mike Pinkerton to give these
changes an overall approval before they are checked in.

Comment 12

[Ludovic Hirlimann [:Usul]]

(In reply to comment #11)
> I think you should get someone like Simon Fraser or Mike Pinkerton to give these
> changes an overall approval before they are checked in.

I plan to ask sfraser for sr

Comment 13

[Ludovic Hirlimann [:Usul]]

Attachment: remove XP_MAC from xpcom/ds

adressing darin's comment and asking smfr for sr

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 172818 [details] [diff] [review]
remove XP_MAC from xpcom/typelib/xpidl

Please, deal with bug 161453 too !

Comment 15

[Ludovic Hirlimann [:Usul]]

(In reply to comment #14)
> (From update of attachment 172818 [details] [diff] [review] [edit])
> Please, deal with bug 161453 too !

Will do once these are gone.

Comment 16

[Doug Turner (:dougt)]

What about the stuff in mozilla/xpcom/reflect/xptcall/src/md/mac/ and other (if
any) mac specific files?

Comment 17

[Ludovic Hirlimann [:Usul]]

(In reply to comment #16)
> What about the stuff in mozilla/xpcom/reflect/xptcall/src/md/mac/ and other (if
> any) mac specific files?

I need to check those and see what can/needs to be done.

Comment 18

[timeless]

i don't see any reason to remove the xptcall impls

Comment 19

[Josh Aas]

landed xpcom/ds and xpcom/base parts

Comment 20

[Josh Aas]

see 281889, comment #24

*** This bug has been marked as a duplicate of 281889 ***