1614711 - Update Neqo to 0.1.13 or later for draft 25 support

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Comment 1

[Chris Peterson [:cpeterson]]

Neqo 0.1.8 is expected to fix bug 1603240 (as per bug 1603240 comment 2).

Comment 2

[Dragana Damjanovic [:dragana]]

(In reply to Chris Peterson [:cpeterson] from comment #1)

Neqo 0.1.8 is expected to fix bug 1603240 (as per bug 1603240 comment 2).

This has been fix already. We did an update to 0.1.12 in December.

Comment 3

[Andy Grover [:grover]]

Attachment: Bug 1614711 - update version to draft 25 r=dragana

Comment 4

[Andy Grover [:grover]]

Attachment: Bug 1614711 - Run mach vendor rust to bring in Neqo 0.1.13 crates r=dragana

Depends on D62508

Comment 5

[Andy Grover [:grover]]

Attachment: Bug 1614711 - Update Neqo crates to 0.1.13 and draft 25 r=dragana

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/848d0ab187f0
Update Neqo crates to 0.1.13 and draft 25 r=dragana

Comment 7

[Daniel Varga [:dvarga]]

Backed out changeset 848d0ab187f0 (Bug 1614711) for causing build bustages with: use of unstable library feature 'mem_take' error

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=288552657&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=848d0ab187f01e31c87cc3ba441839c36f23834e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288551493&repo=autoland&lineNumber=26762

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=51d6068c87a08205495f18c7755fcf24fd628264

[task 2020-02-12T17:02:45.461Z] 17:02:45     INFO -  [neqo-crypto 0.1.13] End of search list.
[task 2020-02-12T17:02:45.465Z] 17:02:45     INFO -       Running `CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_PATCH=13 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/builds/worker/workspace/build/src/obj-firefox/release/deps:/builds/worker/fetches/rustc/lib:/builds/worker/fetches/gcc/lib64:/builds/worker/fetches/gcc/lib32:/builds/worker/fetches/gcc/lib' CARGO_PKG_VERSION=0.1.13 CARGO_PKG_NAME=neqo-crypto CARGO_PKG_DESCRIPTION= OUT_DIR=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/build/neqo-crypto-17e3a342b5398d62/out CARGO_PKG_REPOSITORY= CARGO_MANIFEST_DIR=/builds/worker/workspace/build/src/third_party/rust/neqo-crypto CARGO_PKG_HOMEPAGE= CARGO_PKG_AUTHORS='Martin Thomson <[e-mail]>' CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_PKG_VERSION_MINOR=1 /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --edition=2018 --crate-name neqo_crypto /builds/worker/workspace/build/src/third_party/rust/neqo-crypto/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="deny-warnings"' --cfg 'feature="gecko"' -C metadata=85150ad360e9e7cd -C extra-filename=-85150ad360e9e7cd --out-dir /builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/release/deps --extern log=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/liblog-6dfaf8590d360d8c.rmeta --extern neqo_common=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/libneqo_common-63e49d7cf9ed09c9.rmeta --cap-lints warn -C opt-level=2 -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -L native=/builds/worker/workspace/build/src/obj-firefox/dist/bin -L native=/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/nss/nss_nss3 -L native=/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl3 -L native=/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr -l dylib=nssutil3 -l dylib=nss3 -l dylib=ssl3 -l dylib=plds4 -l dylib=plc4 -l dylib=nspr4`
[task 2020-02-12T17:02:45.465Z] 17:02:45     INFO -     Compiling neqo-transport v0.1.13 (https://github.com/mozilla/neqo?tag=v0.1.13#1bc70df5)
[task 2020-02-12T17:02:45.466Z] 17:02:45     INFO -       Running `CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_PATCH=13 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/builds/worker/workspace/build/src/obj-firefox/release/deps:/builds/worker/fetches/rustc/lib:/builds/worker/fetches/gcc/lib64:/builds/worker/fetches/gcc/lib32:/builds/worker/fetches/gcc/lib' CARGO_PKG_VERSION=0.1.13 CARGO_PKG_NAME=neqo-transport CARGO_PKG_DESCRIPTION= CARGO_PKG_REPOSITORY= CARGO_MANIFEST_DIR=/builds/worker/workspace/build/src/third_party/rust/neqo-transport CARGO_PKG_HOMEPAGE= CARGO_PKG_AUTHORS='EKR <[e-mail]>:Andy Grover <[e-mail]>' CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_PKG_VERSION_MINOR=1 /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --edition=2018 --crate-name neqo_transport /builds/worker/workspace/build/src/third_party/rust/neqo-transport/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="deny-warnings"' -C metadata=df37c970223bdff7 -C extra-filename=-df37c970223bdff7 --out-dir /builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/release/deps --extern lazy_static=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/liblazy_static-94eb03ee988175a1.rmeta --extern log=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/liblog-6dfaf8590d360d8c.rmeta --extern neqo_common=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/libneqo_common-63e49d7cf9ed09c9.rmeta --extern neqo_crypto=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/libneqo_crypto-85150ad360e9e7cd.rmeta --extern smallvec=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/libsmallvec-00452618345e612b.rmeta --cap-lints warn -C opt-level=2 -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -L native=/builds/worker/workspace/build/src/obj-firefox/dist/bin -L native=/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/nss/nss_nss3 -L native=/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl3 -L native=/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr`
[task 2020-02-12T17:02:45.466Z] 17:02:45    ERROR -  error[E0658]: use of unstable library feature 'mem_take'
[task 2020-02-12T17:02:45.467Z] 17:02:45     INFO -     --> /builds/worker/workspace/build/src/third_party/rust/neqo-transport/src/crypto.rs:842:36
[task 2020-02-12T17:02:45.467Z] 17:02:45     INFO -      |
[task 2020-02-12T17:02:45.467Z] 17:02:45     INFO -  842 |                         handshake: mem::take(handshake),
[task 2020-02-12T17:02:45.467Z] 17:02:45     INFO -      |                                    ^^^^^^^^^
[task 2020-02-12T17:02:45.467Z] 17:02:45     INFO -      |
[task 2020-02-12T17:02:45.468Z] 17:02:45     INFO -      = note: for more information, see https://github.com/rust-lang/rust/issues/61129
[task 2020-02-12T17:02:45.468Z] 17:02:45    ERROR -  error[E0658]: use of unstable library feature 'mem_take'
[task 2020-02-12T17:02:45.468Z] 17:02:45     INFO -     --> /builds/worker/workspace/build/src/third_party/rust/neqo-transport/src/crypto.rs:843:38
[task 2020-02-12T17:02:45.468Z] 17:02:45     INFO -      |
[task 2020-02-12T17:02:45.468Z] 17:02:45     INFO -  843 |                         application: mem::take(application),
[task 2020-02-12T17:02:45.469Z] 17:02:45     INFO -      |                                      ^^^^^^^^^
[task 2020-02-12T17:02:45.469Z] 17:02:45     INFO -      |
[task 2020-02-12T17:02:45.469Z] 17:02:45     INFO -      = note: for more information, see https://github.com/rust-lang/rust/issues/61129
[task 2020-02-12T17:02:45.469Z] 17:02:45    ERROR -  error[E0658]: use of unstable library feature 'mem_take'
[task 2020-02-12T17:02:45.470Z] 17:02:45     INFO -     --> /builds/worker/workspace/build/src/third_party/rust/neqo-transport/src/crypto.rs:850:38
[task 2020-02-12T17:02:45.470Z] 17:02:45     INFO -      |
[task 2020-02-12T17:02:45.470Z] 17:02:45     INFO -  850 |                         application: mem::take(application),
[task 2020-02-12T17:02:45.470Z] 17:02:45     INFO -      |                                      ^^^^^^^^^
[task 2020-02-12T17:02:45.470Z] 17:02:45     INFO -      |
[task 2020-02-12T17:02:45.470Z] 17:02:45     INFO -      = note: for more information, see https://github.com/rust-lang/rust/issues/61129
[task 2020-02-12T17:02:45.471Z] 17:02:45     INFO -  error: aborting due to 3 previous errors
[task 2020-02-12T17:02:45.471Z] 17:02:45     INFO -  For more information about this error, try `rustc --explain E0658`.
[task 2020-02-12T17:02:45.471Z] 17:02:45     INFO -  error: could not compile `neqo-transport`.
[task 2020-02-12T17:02:45.471Z] 17:02:45     INFO -  Caused by:
[task 2020-02-12T17:02:45.475Z] 17:02:45     INFO -    process didn't exit successfully: `CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_PATCH=13 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/builds/worker/workspace/build/src/obj-firefox/release/deps:/builds/worker/fetches/rustc/lib:/builds/worker/fetches/gcc/lib64:/builds/worker/fetches/gcc/lib32:/builds/worker/fetches/gcc/lib' CARGO_PKG_VERSION=0.1.13 CARGO_PKG_NAME=neqo-transport CARGO_PKG_DESCRIPTION= CARGO_PKG_REPOSITORY= CARGO_MANIFEST_DIR=/builds/worker/workspace/build/src/third_party/rust/neqo-transport CARGO_PKG_HOMEPAGE= CARGO_PKG_AUTHORS='EKR <[e-mail]>:Andy Grover <[e-mail]>' CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_PKG_VERSION_MINOR=1 /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --edition=2018 --crate-name neqo_transport /builds/worker/workspace/build/src/third_party/rust/neqo-transport/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C codegen-units=1 --cfg 'feature="default"' --cfg 'feature="deny-warnings"' -C metadata=df37c970223bdff7 -C extra-filename=-df37c970223bdff7 --out-dir /builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/release/deps --extern lazy_static=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/liblazy_static-94eb03ee988175a1.rmeta --extern log=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/liblog-6dfaf8590d360d8c.rmeta --extern neqo_common=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/libneqo_common-63e49d7cf9ed09c9.rmeta --extern neqo_crypto=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/libneqo_crypto-85150ad360e9e7cd.rmeta --extern smallvec=/builds/worker/workspace/build/src/obj-firefox/x86_64-unknown-linux-gnu/release/deps/libsmallvec-00452618345e612b.rmeta --cap-lints warn -C opt-level=2 -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -L native=/builds/worker/workspace/build/src/obj-firefox/dist/bin -L native=/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/nss/nss_nss3 -L native=/builds/worker/workspace/build/src/obj-firefox/security/nss/lib/ssl/ssl_ssl3 -L native=/builds/worker/workspace/build/src/obj-firefox/config/external/nspr/pr` (exit code: 1)
[task 2020-02-12T17:02:45.475Z] 17:02:45     INFO -  warning: build failed, waiting for other jobs to finish...

Comment 8

[Andy Grover [:grover]]

Attachment: Bug 1614711 - Update to Neqo 0.1.14 for support for QUIC draft 25 r=dragana

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6e7f733e07a
Update to Neqo 0.1.14 for support for QUIC draft 25 r=dragana

Comment 10

[Cristina Coroiu [:ccoroiu]]

Backed out changeset b6e7f733e07a (bug 1614711) for build bustages at third_party/rust/neqo-crypto/src/lib.rs

Backout: https://hg.mozilla.org/integration/autoland/rev/51dbdcd6e874c5d466f7a163e43973358e06284d

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b6e7f733e07a233631ee0975174e642a4a61840c

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288778825&repo=autoland&lineNumber=38714

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ff9e5abe894
Update to Neqo 0.1.14 for support for QUIC draft 25 r=dragana

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9ff9e5abe894

Comment 13

[Intermittent Failures Robot]

1 failures in 4690 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1614711&startday=2020-02-10&endday=2020-02-16&tree=all