1614854 - Add UrlbarPrefs.set()

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Drew Willcoxon :adw]

We might want to add a UrlbarPrefs.setPref function (or setIntPref, etc.). We have getPref, which should not be passed the browser.urlbar pref name prefix. But since we don't have a setPref, we have to use the prefs service directly, where we do need to use the browser.urlbar prefix. That inconsistency can contribute to bugs like bug 1614656.

Comment 1

[Mike de Boer [:mikedeboer]]

I'd recommend a simple API, mirroring getPref, with a similar type checking/ switching implementation as Preferences.jsm has. My 2cts :)

Comment 2

[Marco Bonardo [:mak]]

UrlbarPrefs is shaped after Map, thus it should just be .set(key, value); it should only be able to set known prefs, and the type of the pref can be extracted from the default value that is defined in its internal table. Thus it should throw for an unknown pref or a non-coherent type for the passed-in value.

Comment 3

[Drew Willcoxon :adw]

Yes, I was thinking along those lines too.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1614854 - Add UrlbarPrefs.set(). r=adw

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf410c350fe7
Add UrlbarPrefs.set(). r=adw

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset cf410c350fe7 for causing xpcshell failures in test_UrlbarPrefs.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5d0ed72bfb1f0706c1b2f1011aa31b724f1fef09

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=cf410c350fe77b3b56702d1038cc0f060e3e1e54&selectedJob=291404289

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291404289&repo=autoland&lineNumber=6482

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e48b9c47bfd
Add UrlbarPrefs.set(). r=adw

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7e48b9c47bfd