Closed
Bug 1614956
Opened 5 years ago
Closed 5 years ago
Wrong aForceStripOA parameter passed to GetKeyForOrigin() inside nsPermissionManager::GetPermissionsWithKey()
Categories
(Core :: Permission Manager, defect)
Core
Permission Manager
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox73 | --- | unaffected |
| firefox74 | --- | wontfix |
| firefox75 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: emz)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
See the code. aPermissionKey is not a permission type, so it's not useful to pass it to IsOAForceStripPermission(), the result will always be false.
This code is used in pair with this one so I think the right thing to do here is to just pass false unconditionally (perhaps with a comment around both...).
Paul, would you like to take this?
Flags: needinfo?
|
Reporter | |
Updated•5 years ago
|
Flags: needinfo? → needinfo?(pbz)
|
Assignee | |
Comment 1•5 years ago
|
||
I'll have a look. Thanks!
Assignee: nobody → pbz
Status: NEW → ASSIGNED
Flags: needinfo?(pbz)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fab6a1ca1a6
Removed invalid IsOAForceStripPermission call in nsPermissionManager. r=Ehsan
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
|
||
Comment 5•5 years ago
|
||
Is there a user-facing issue from this bug which would justify Beta uplift consideration or can this fix ride 75 to release?
status-firefox73:
--- → unaffected
status-firefox74:
--- → affected
status-firefox-esr68:
--- → unaffected
Flags: needinfo?(pbz)
|
|
Assignee | |
Comment 6•5 years ago
|
||
This is not user-facing and doesn't need an uplift. Thanks!
Flags: needinfo?(pbz)
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•