Closed Bug 1591748 Opened 5 years ago Closed 5 years ago

"Exceptions - Cookies and Site Data" are ignored when setting "Always use private browsing mode".

Categories

(Core :: Permission Manager, defect, P2)

72 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- fixed

People

(Reporter: suishouen, Assigned: pbz)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

  1. Open "about:preferences#privacy" -> "Manage Permissions…" .
  2. Set "https://bugzilla.mozilla.org/home" to "Allow for Session" and save.
  3. Set "Always use private browsing mode" in "Privacy & Security" preferences.
  4. Open "https://bugzilla.mozilla.org/home" and try to log in.

Actual results:

"Allow for Session" is ignored and I can't log in.

Expected results:

"Allow for Session" is not ignored and I can log in as Firefox Developer Edition 71.0b4 can do.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Preferences
Attached image Screenshots.png

Screenshots of Site Information Panel

Summary: When setting "Always use private browsing mode", "Exceptions - Cookies and Site Data" are ignored. → "Exceptions - Cookies and Site Data" are ignored when setting "Always use private browsing mode".

Ah, the cookie exceptions problem again, this time for privateBrowsingId. This is bug 1556212, but it might make sense to track separately. What happens here is that we added support for more origin attributes for permissions, but the cookies permission is added without OAs in about:preferences.

Status: UNCONFIRMED → NEW
Component: Preferences → Permission Manager
Ever confirmed: true
Keywords: regression
Priority: -- → P2
Product: Firefox → Core
Regressed by: 1422056
See Also: → 1556212

FWIW setting permissions.isolateBy.privateBrowsing to false in about:config should fix this for you momentarily.

(In reply to Johann Hofmann [:johannh] from comment #4)

FWIW setting permissions.isolateBy.privateBrowsing to false in about:config should fix this for you momentarily.

Thanks for your a quick help.
I confirmed that setting permissions.isolateBy.privateBrowsing to false has fixed this issue.

Assignee: nobody → pbz
Status: NEW → ASSIGNED

I'd like to reuse this patch originally planned for a similar FPI bug: https://phabricator.services.mozilla.com/D53191, but only have it strip private browsing / user context, not FPI.
Just making sure, since this doesn't touch FPI origin attributes, would it be ok from the tor browse side, Tom?

Flags: needinfo?(tom)

Yes, that should be fine, thanks for checking.

Flags: needinfo?(tom)
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94d8942709df
nsPermissionMgr: Added principal oa strip permission list for userContext and privateBrowsing. r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/18fe0c505632
Added test for oa strip permission list. r=Ehsan
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9902221ac174
nsPermissionMgr: Added principal oa strip permission list for userContext and privateBrowsing. r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/34dd9b331df3
Added test for oa strip permission list. r=Ehsan
Flags: needinfo?(pbz)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Is the user impact of this bug severe enough that we should consider uplifting this fix to Beta for Fx73 or can this ride Fx74 to release? Please nominate the patch for approval if you feel it should be uplifted. It grafts cleanly as-landed.

Flags: needinfo?(pbz)
Flags: in-testsuite+

Thanks Ryan! I don't think we need to uplift this. The issue only affects pre-release channels and is rather an edge case.

Flags: needinfo?(pbz)
Depends on: 1560947
Regressions: 1614956
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: