1615091 - Hit MOZ_CRASH(called `Option::unwrap()` on a `None` value) at /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libcore/macros/mod.rs:15

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Reduced with m-c 20200212-f314754b7e11

Hit MOZ_CRASH(called Option::unwrap() on a None value) at /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libcore/macros/mod.rs:15

#0 MOZ_Crash(char const*, int, char const*) src/obj-firefox/dist/include/mozilla/Assertions.h:331:3
#1 RustMozCrash src/mozglue/static/rust/wrappers.cpp:17:3
#2 mozglue_static::panic_hook::hfb0ed382a16f67d7 src/mozglue/static/rust/lib.rs:89:8
#3 core::ops::function::Fn::call::hc4969999b3cfd320 /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libcore/ops/function.rs:72:4
#4 std::panicking::rust_panic_with_hook::h787d7f532b084b9a /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libstd/panicking.rs:475:16
#5 rust_begin_unwind /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libstd/panicking.rs:375:4
#6 core::panicking::panic_fmt::h76b979c035808e69 /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libcore/panicking.rs:84:13
#7 core::panicking::panic::hf3b2e3f8bf85ebd1 /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libcore/panicking.rs:51:4
#8 webrender::picture::PicturePrimitive::resolve_split_planes::ha9679a283ac82cdb src/gfx/wr/webrender/src/picture.rs
#9 webrender::picture::PicturePrimitive::prepare_for_render::h831970aa5dfdd939 src/gfx/wr/webrender/src/picture.rs:5048:12
#10 webrender::prim_store::PrimitiveStore::prepare_interned_prim_for_render::h5bfc47728d1f0d42 src/gfx/wr/webrender/src/prim_store/mod.rs:3336:19
#11 webrender::prim_store::PrimitiveStore::prepare_prim_for_render::h5a1edfad07b76e7f src/gfx/wr/webrender/src/prim_store/mod.rs:2769:8
#12 webrender::prim_store::PrimitiveStore::prepare_primitives::h3e86d2badb99faae src/gfx/wr/webrender/src/prim_store/mod.rs:2829:19
#13 webrender::prim_store::PrimitiveStore::prepare_prim_for_render::h5a1edfad07b76e7f src/gfx/wr/webrender/src/prim_store/mod.rs:2718:16
#14 webrender::prim_store::PrimitiveStore::prepare_primitives::h3e86d2badb99faae src/gfx/wr/webrender/src/prim_store/mod.rs:2829:19
#15 webrender::frame_builder::FrameBuilder::build_layer_screen_rects_and_cull_layers::h66645f1c40fb3ba1 src/gfx/wr/webrender/src/frame_builder.rs:449:12
#16 webrender::frame_builder::FrameBuilder::build::hdefc195077481839 src/gfx/wr/webrender/src/frame_builder.rs:554:34
#17 webrender::render_backend::Document::build_frame::h36fd4df17a943390 src/gfx/wr/webrender/src/render_backend.rs:556:24
#18 webrender::render_backend::RenderBackend::update_document::h267d7b365fd2c021 src/gfx/wr/webrender/src/render_backend.rs:1577:40
#19 webrender::render_backend::RenderBackend::prepare_transactions::hfe24f58e10e07297 src/gfx/wr/webrender/src/render_backend.rs:1410:16
#20 webrender::render_backend::RenderBackend::process_api_msg::hb3037832a3090049 src/gfx/wr/webrender/src/render_backend.rs:1302:16
#21 webrender::render_backend::RenderBackend::run::h4a12cd5d229ad374 src/gfx/wr/webrender/src/render_backend.rs:1000:20
#22 webrender::renderer::Renderer::new::_$u7b$$u7b$closure$u7d$$u7d$::h9b3efa3f5a3f7de7 src/gfx/wr/webrender/src/renderer.rs:2336:12
#23 std::sys_common::backtrace::__rust_begin_short_backtrace::h9cb9058a815d700e /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libstd/sys_common/backtrace.rs:136:4
#24 std::thread::Builder::spawn_unchecked::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h7666c4e9fbc8561d /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libstd/thread/mod.rs:469:16
#25 _$LT$std..panic..AssertUnwindSafe$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$$LP$$RP$$GT$$GT$::call_once::ha4a0c8293fb24fca /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libstd/panic.rs:318:8
#26 std::panicking::try::do_call::h802aef7cdbaa3cdb (.llvm.17200670927788590943) /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libstd/panicking.rs:292:39
#27 __rust_maybe_catch_panic /rustc/5e1a799842ba6ed4a57e91f7ab9435947482f7d8/src/libpanic_abort/lib.rs:28:4

Comment 1

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/2PPWM1CNyFExHGKH6NsevQ/index.html

Comment 2

[Glenn Watson [:gw]]

Attachment: Bug 1615091 - Fix panic in resolve_split_planes with invalid transform.

Comment 3

[Glenn Watson [:gw]]

Attached patch resolves this panic.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d76363fefb2
Fix panic in resolve_split_planes with invalid transform. r=nical

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9d76363fefb2