1615156 - Fix KeyframeEffect::ContainsAnimatedScale for cases we have no base style.

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

The baseStyle is only set if there is an add/accumulate animation. So the code there should be;

AnimationValue baseStyle = BaseStyle(prop.mProperty);                       
if (!baseStyle.IsNull()) {                                                   
  gfx::Size size = baseStyle.GetScaleValue(aFrame);                         
  if (size != gfx::Size(1.0f, 1.0f)) {                                      
    return true;                                                            
  }                                                                         
} 

I am going to fix this soon. That's said it's not with any automated tests since as far as I can tell this is not testable. There is another underlying issue which caused bug 1614788. And the underlying issue obscured this issue, as far as I can tell.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1615156 - Don't return true from KeyframeEffect::ContainsAnimatedScale if there is no base style. r?boris

The base style is not set in cases where there is no additive/accumulative
animation.

Comment 2

[Timothy Nikkel (:tnikkel)]

Thanks for patching this!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45c632e12bd6
Don't return true from KeyframeEffect::ContainsAnimatedScale if there is no base style. r=boris

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/45c632e12bd6