[Approval Request Comment]
Regression caused by (bug #): 1442925
User impact if declined: clearing search histroy does not work. Needs to be cleared in the data manager
Testing completed (on m-c, etc.): 2.53 2.57(has issues)
Risk to taking this patch (and alternatives if risky): none already broken.
String changes made by this patch: --
The safest approach seems to be an additional FormHistory import in the text box. It was done differently with just an import before Bug 1442925 but seems to be cleaner using a field now.
At least the sidebar search field does not habe a searchbar and also not a parent Binding (second problem discovered and fixed) so we can't just use the Formhistory from the searchbar.
Does not throw in 2.57 but also not removing history because of other problems which need to be fixed first. The patch should then work fine for it too.
Btw. just opening a customize toolbar box constructs a search box but never calls the destructor. Something to fix for later and not related to the existing bugs here.