1615275 - Intermittent GECKO(2254) | SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/build/src/gfx/layers/apz/src/Axis.cpp:358:42 in GetVelocity

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: choller [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=288706553&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HMvu2BrZSG-0Ylo6xmC09w/runs/0/artifacts/public/logs/live_backing.log

---

This is a data race on the mAxisLocked member.

Comment 1

[Christian Holler (:decoder)]

Attaching the TSan trace for better readability and to preserve it. This is for autoland revision b61bb41f31d147a3fd1ba875bbf73abb56286e67.

Comment 2

[Christian Holler (:decoder)]

Attachment: Detailed Crash Information

Comment 3

[Christian Holler (:decoder)]

Attachment: Bug 1615275 - Add temporary suppression for GetVelocity data race. r?botond

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5525a5b1d1c6
Add temporary suppression for GetVelocity data race. r=mccr8

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5525a5b1d1c6

Comment 6

[Intermittent Failures Robot]

10 failures in 4690 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9
• mozilla-central: 1

Platform breakdown:

• linux64-tsan: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1615275&startday=2020-02-10&endday=2020-02-16&tree=all

Comment 7

[Botond Ballo [:botond]]

We should fix this properly and remove the suppression.

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1615275 - Hold the APZC lock while calling Axis::EndTouch(). r=kats

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1615275 - Remove the temporary suppression added previously. r=decoder

Depends on D64484

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea8b987cc1c9
Hold the APZC lock while calling Axis::EndTouch(). r=kats
https://hg.mozilla.org/integration/autoland/rev/a86295ff4cc6
Remove the temporary suppression added previously. r=decoder

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ea8b987cc1c9
https://hg.mozilla.org/mozilla-central/rev/a86295ff4cc6

Comment 12

[Botond Ballo [:botond]]

Whoops, forgot to remove the leave-open keyword.