1615403 - Wrap {Browsing,Window}Context objects sent over IPC with MaybeDiscarded

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

There have been various issues, such as bug 1612894, over time due to crashes caused by code not checking for IsDiscarded before sending a BrowsingContext over IPC. This bug adds a new MaybeDiscarded wrapper type which allows sending a discarded BrowsingContext over IPC to another process. Helper IsNullOrDiscarded, IsNull, and IsDiscarded methods make validating that the BrowsingContext is valid easier and more explicit.

In addition, serializers for BrowsingContext* and WindowContext* are removed, allowing this issue to be avoided in the future.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 1: Introduce a new MaybeDiscarded type,

Adds a new MaybeDiscarded wrapper type which allows sending a maybe-discarded
BrowsingContext over IPC to another process which must be explicitly checked for
nullness and discarded status before being used.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 2: Use MaybeDiscarded for direct IPC arguments,

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 3: Use MaybeDiscarded for postMessage source,

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 4: Use MaybeDiscarded for PSHistory,

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 5: Use MaybeDiscarded for RestoreBrowsingContextChildren,

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 6: Use MaybeDiscarded for WindowGlobalInit,

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 9: Remove old BrowsingContext & WindowContext serializers,

These serializers have been superceded by the new
MaybeDiscarded<BrowsingContext> and MaybeDiscarded<WindowContext> serializers
added in earlier parts.

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 7: Use MaybeDiscarded for PExternalAppHelperParent,

Comment 9

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1615403 - Part 8: Use MaybeDiscarded for new focus methods,

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bf5b4421e52
Part 1: Introduce a new MaybeDiscarded type, r=farre
https://hg.mozilla.org/integration/autoland/rev/061325bfa2b7
Part 2: Use MaybeDiscarded for direct IPC arguments, r=farre
https://hg.mozilla.org/integration/autoland/rev/aca2e3d525ca
Part 3: Use MaybeDiscarded for postMessage source, r=farre
https://hg.mozilla.org/integration/autoland/rev/08f1d33f2661
Part 4: Use MaybeDiscarded for PSHistory, r=peterv
https://hg.mozilla.org/integration/autoland/rev/47a116922e81
Part 5: Use MaybeDiscarded for RestoreBrowsingContextChildren, r=farre
https://hg.mozilla.org/integration/autoland/rev/be2f00ff66e6
Part 6: Use MaybeDiscarded for WindowGlobalInit, r=farre
https://hg.mozilla.org/integration/autoland/rev/69ece5421024
Part 7: Use MaybeDiscarded for PExternalAppHelperParent, r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/4ee2aa96e99a
Part 8: Use MaybeDiscarded for new focus methods, r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/3c87f77c919c
Part 9: Remove old BrowsingContext & WindowContext serializers, r=farre

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1bf5b4421e52
https://hg.mozilla.org/mozilla-central/rev/061325bfa2b7
https://hg.mozilla.org/mozilla-central/rev/aca2e3d525ca
https://hg.mozilla.org/mozilla-central/rev/08f1d33f2661
https://hg.mozilla.org/mozilla-central/rev/47a116922e81
https://hg.mozilla.org/mozilla-central/rev/be2f00ff66e6
https://hg.mozilla.org/mozilla-central/rev/69ece5421024
https://hg.mozilla.org/mozilla-central/rev/4ee2aa96e99a
https://hg.mozilla.org/mozilla-central/rev/3c87f77c919c

Comment 13

[Oana Pop-Rus]

Hi, could you please take a look at this gv-junit multiple failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&fromchange=6da7cf8a6742e5c82833cdd2fbc58ae5010703df&searchStr=android%2C7.0%2Cx86-64%2Copt%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-junit-e10s%2C%28gv-junit%29&selectedJob=289899724

Since this bug was landed, this failure become very frequent.

Thank you.

Comment 14

[Nika Layzell [:nika] (ni? for response)]

I've been looking into this, and now have a ni? on bug 1617063. Clearing my ni? here.