Open Bug 1623989 Opened 1 year ago Updated 1 month ago

Add MaybeDiscarded-like wrapper for sending BrowsingContext from JS

Categories

(Core :: DOM: Content Processes, task, P3)

task

Tracking

()

Fission Milestone M8

People

(Reporter: cpeterson, Assigned: kmag, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: fission-design-needed)

This change will help prevent IPC message crashes like bp-1ec19da7-8bfc-4eea-9b7e-c7a030190705 in bug 1563825.

Chris, do you remember how the conclusion was reached that this would help with those crashes? Was that just speculation or is there something in those crash reports that indicates that sending discarded BCs is the issue?

Flags: needinfo?(cpeterson)

(In reply to Andrew McCreight [:mccr8] from comment #1)

Chris, do you remember how the conclusion was reached that this would help with those crashes? Was that just speculation or is there something in those crash reports that indicates that sending discarded BCs is the issue?

Redirecting needinfo to Nika because I think she suggested this solution. She was writing MaybeDiscarded (bug 1615403) at that time.

The ReceiveRawMessage crash volume in bug 1563824 looks pretty high for a Nightly crash (about 20-40 crash reports/day).

No longer blocks: 1615403
Depends on: 1615403
Flags: needinfo?(cpeterson) → needinfo?(nika)

From the research that :mccr8 did in that bug by looking at what messages were failing, it doesn't seem like they tend to be failing due to a missing BrowsingContext instance. Many of the messages which are failing seem to be failing for other odd reasons.

IIRC the reason why I thought this might help was due to speculation that the deserialization failures were caused by discarded BCs, yes.

Flags: needinfo?(nika)

As discussed in the Fission meeting and also mentioned in comment 3, this is most likely not a cause of the crashes and not a major issue right now. We should table this for later.

Fission Milestone: M6a → M6c
Fission Milestone: M6c → M7
Priority: P1 → P3

I'm still unsure what the design for this should look like, and it doesn't seem like it's the cause of the specific ReceiveRawMessage crashes we're running into. We might be able to avoid doing this?

:kmag, do you know what design you'd want for this if we did add it or something like it?

Flags: needinfo?(kmaglione+bmo)
Whiteboard: fission-design-needed
Assignee: nobody → kmaglione+bmo
Flags: needinfo?(kmaglione+bmo)

Not a beta blocker. kmag and nika continue to discussing the design for this.

Fission Milestone: M7 → M8

Kris, can you add a comment here describing the design that you have thought of?

Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.