1615539 - about:memory > Measure does not work

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P1)

Description

[Alice0775 White]

Reproducible: always

Steps To Reproduce:

1. Open about:memory
   2.Click [Measure] button

Actual results:
No report appears.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e584a5e51a9429a7979f0ee71fd301eda6c0ce6a&tochange=b2dbb80db8558835ec032c5f5811c91a4f4d5da4

Comment 2

[Alice0775 White]

Browser Console indicates an error as follows when I click [Measure] button:

Error: Invalid memory report(s): bad explicit kind aboutMemory.js:110:11
    assertInput chrome://global/content/aboutMemory.js:110
    handleReport chrome://global/content/aboutMemory.js:1157
    processCurrentMemoryReports chrome://global/content/aboutMemory.js:686
    appendAboutMemoryMain chrome://global/content/aboutMemory.js:1406
    updateAboutMemoryFromCurrentData chrome://global/content/aboutMemory.js:700
    displayReports chrome://global/content/aboutMemory.js:642

Comment 3

[Pascal Chevrel:pascalc]

Thanks Alice!
Andrew, it seems that your patch in bug 1612589 caused this regression in our upcoming 74 release, could you have a look please? Thanks!

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Ah this is likely Windows only, due to the D2D surfaces.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1615539 - Fix explicit image memory reporting broken on Windows.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10d8c314b394
Fix explicit image memory reporting broken on Windows. r=jrmuizel

Comment 7

[Timothy Nikkel (:tnikkel)]

We'll need this on beta, correct?

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Yup. Just waiting for it to get into a build so I can verify it.

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/10d8c314b394

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9126707 [details]
Bug 1615539 - Fix explicit image memory reporting broken on Windows.

Beta/Release Uplift Approval Request

• User impact if declined: Won't be able to generate memory reports on Windows.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial change, switches an enum type to be more acceptable.
• String changes made/needed:

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9126707 [details]
Bug 1615539 - Fix explicit image memory reporting broken on Windows.

74 regression, simple fix, uplift approved for the next beta, thanks.

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dcc5fa49cdd3