hiddenwindow errors on macOS with chat
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(thunderbird_esr68 unaffected, thunderbird74 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr68 | --- | unaffected |
thunderbird74 | --- | fixed |
People
(Reporter: rjl, Assigned: mkmelin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files, 1 obsolete file)
146.47 KB,
image/png
|
Details | |
97.31 KB,
image/png
|
Details | |
5.62 KB,
patch
|
pmorris
:
review+
khushil324
:
feedback+
mkmelin
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
135.26 KB,
text/plain
|
Details |
I'm not able to connect to an IRC server with Thunderbird 74.0b1-build3.
The Developer tools console has errors referring to "hiddenwindow.jsm".
Same test on Linux worked.
Comment 1•5 years ago
|
||
Magnus / Florian, any idea what might be going on here?
Assignee | ||
Comment 2•5 years ago
|
||
Don't know why it would happen.
But maybe instead of the hiddenWindow.jsm getHiddenHTMLWindow should just be Services.appShell.createWindowlessBrowser()?
Comment 3•5 years ago
|
||
On first start to the normal three-pane window I see this message:
XML Parsing Error: undefined entity
Location: chrome://messenger/content/hiddenWindow.xhtml
Line Number 621, Column 15:
It points to:
<menuitem id="calendar-new-event-menuitem"
label="&lightning.menupopup.new.event.label;"
accesskey="&lightning.menupopup.new.event.accesskey;"
key="calendar-new-event-key"
command="calendar_new_event_command"/>
and those calendar entries definitely aren't shown.
Rob, do you see this if you look earlier at startup?
I'm thinking that bug 1608610 probably didn't take account of affecting the hidden window when adding to mainNavigationToolbox.inc.xhtml.
Updated•5 years ago
|
Reporter | ||
Comment 5•5 years ago
|
||
Yes that exact error.
(In reply to Mark Banner (:standard8) from comment #3)
On first start to the normal three-pane window I see this message:
XML Parsing Error: undefined entity Location: chrome://messenger/content/hiddenWindow.xhtml Line Number 621, Column 15:
It points to:
<menuitem id="calendar-new-event-menuitem" label="&lightning.menupopup.new.event.label;" accesskey="&lightning.menupopup.new.event.accesskey;" key="calendar-new-event-key" command="calendar_new_event_command"/>
and those calendar entries definitely aren't shown.
Rob, do you see this if you look earlier at startup?
I'm thinking that bug 1608610 probably didn't take account of affecting the hidden window when adding to mainNavigationToolbox.inc.xhtml.
Reporter | ||
Comment 6•5 years ago
|
||
I ran the build Magnus did on try withj this patch and I no longer get the hiddenWindow error. I was able to connect to an IRC server, but as soon as I joined a channel, Thunderbird crashed. Devtools stayed running though so I was able to get the screenshot.
Assignee | ||
Comment 7•5 years ago
|
||
Comment on attachment 9126977 [details] [diff] [review] bug1615714_mac_hiddenwin.patch Looks like still some entity missing. Khushil, can you check it out?
Comment 8•5 years ago
|
||
I'm not 100% sure, but there might need to be some Javascript inclusions as well, so the menu options keep working when all other windows are closed.
Assignee | ||
Comment 9•5 years ago
|
||
Yeah, probably more or less all of https://searchfox.org/comm-central/rev/505f5146a83137539702acdd4ecd8bb4b4280b7b/mail/base/content/messenger.xhtml#218-297
Comment 12•5 years ago
|
||
Comment on attachment 9127079 [details] [diff] [review] bug1615714_mac_hiddenwin.patch Review of attachment 9127079 [details] [diff] [review]: ----------------------------------------------------------------- It's working. IRC account is getting connected.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Comment on attachment 9127079 [details] [diff] [review] bug1615714_mac_hiddenwin.patch Review of attachment 9127079 [details] [diff] [review]: ----------------------------------------------------------------- Changes look good. I don't have a mac so I can't test. It would be worth adding comments to messenger.xhtml and hiddenWindow.xhtml saying that any changes to DTD and JS scripts need to be made in both places. Or even better, put the common items in one or more include files and include them in both places (to avoid having to remember to make changes in two places).
Assignee | ||
Comment 14•5 years ago
|
||
Yeah we need to put more of these in includes.
Comment 15•5 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9929fcef2872
fix hiddenwindow errors on macOS - include the scrips and dtds that are in messenger.xhtml. r=pmorris
Assignee | ||
Comment 17•5 years ago
|
||
Comment on attachment 9127079 [details] [diff] [review] bug1615714_mac_hiddenwin.patch Review of attachment 9127079 [details] [diff] [review]: ----------------------------------------------------------------- We should
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 18•5 years ago
|
||
bugherder uplift |
Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/35335f53d59d
Reporter | ||
Updated•5 years ago
|
Description
•