1615714 - hiddenwindow errors on macOS with chat

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Rob Lemley [:rjl]]

Attachment: image.png

I'm not able to connect to an IRC server with Thunderbird 74.0b1-build3.

The Developer tools console has errors referring to "hiddenwindow.jsm".

Same test on Linux worked.

Comment 1

[Patrick Cloke [:clokep]]

Magnus / Florian, any idea what might be going on here?

Comment 2

[Magnus Melin [:mkmelin]]

Don't know why it would happen.
But maybe instead of the hiddenWindow.jsm getHiddenHTMLWindow should just be Services.appShell.createWindowlessBrowser()?

Comment 3

[Mark Banner (:standard8)]

On first start to the normal three-pane window I see this message:

XML Parsing Error: undefined entity
Location: chrome://messenger/content/hiddenWindow.xhtml
Line Number 621, Column 15:

It points to:

              <menuitem id="calendar-new-event-menuitem"
                        label="&lightning.menupopup.new.event.label;"
                        accesskey="&lightning.menupopup.new.event.accesskey;"
                        key="calendar-new-event-key"
                        command="calendar_new_event_command"/>

and those calendar entries definitely aren't shown.

Rob, do you see this if you look earlier at startup?

I'm thinking that bug 1608610 probably didn't take account of affecting the hidden window when adding to mainNavigationToolbox.inc.xhtml.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1615714_mac_hiddenwin.patch

Add missing dtds. Someone with a mac should check.

Comment 5

[Rob Lemley [:rjl]]

Yes that exact error.

(In reply to Mark Banner (:standard8) from comment #3)

On first start to the normal three-pane window I see this message:

XML Parsing Error: undefined entity
Location: chrome://messenger/content/hiddenWindow.xhtml
Line Number 621, Column 15:

It points to:

              <menuitem id="calendar-new-event-menuitem"
                        label="&lightning.menupopup.new.event.label;"
                        accesskey="&lightning.menupopup.new.event.accesskey;"
                        key="calendar-new-event-key"
                        command="calendar_new_event_command"/>

and those calendar entries definitely aren't shown.

Rob, do you see this if you look earlier at startup?

I'm thinking that bug 1608610 probably didn't take account of affecting the hidden window when adding to mainNavigationToolbox.inc.xhtml.

Comment 6

[Rob Lemley [:rjl]]

Attachment: image2.png

I ran the build Magnus did on try withj this patch and I no longer get the hiddenWindow error. I was able to connect to an IRC server, but as soon as I joined a channel, Thunderbird crashed. Devtools stayed running though so I was able to get the screenshot.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9126977 [details] [diff] [review]
bug1615714_mac_hiddenwin.patch

Looks like still some entity missing. Khushil, can you check it out?

Comment 8

[Mark Banner (:standard8)]

I'm not 100% sure, but there might need to be some Javascript inclusions as well, so the menu options keep working when all other windows are closed.

Comment 9

[Magnus Melin [:mkmelin]]

Yeah, probably more or less all of https://searchfox.org/comm-central/rev/505f5146a83137539702acdd4ecd8bb4b4280b7b/mail/base/content/messenger.xhtml#218-297

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1615714_mac_hiddenwin.patch

Added the scripts.

Comment 11

[Rob Lemley [:rjl]]

Attachment: crash.txt

Not sure if this is helpful or not?

Comment 12

[Khushil Mistry [:khushil324]]

Comment on attachment 9127079 [details] [diff] [review]
bug1615714_mac_hiddenwin.patch

Review of attachment 9127079 [details] [diff] [review]:
-----------------------------------------------------------------

It's working. IRC account is getting connected.

Comment 13

[Paul Morris [:pmorris]]

Comment on attachment 9127079 [details] [diff] [review]
bug1615714_mac_hiddenwin.patch

Review of attachment 9127079 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good.  I don't have a mac so I can't test.  It would be worth adding comments to messenger.xhtml and hiddenWindow.xhtml saying that any changes to DTD and JS scripts need to be made in both places.  Or even better, put the common items in one or more include files and include them in both places (to avoid having to remember to make changes in two places).

Comment 14

[Magnus Melin [:mkmelin]]

Yeah we need to put more of these in includes.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9929fcef2872
fix hiddenwindow errors on macOS - include the scrips and dtds that are in messenger.xhtml. r=pmorris

Comment 16

[Patrick Cloke [:clokep]]

Should we uplift this to beta?

Comment 17

[Magnus Melin [:mkmelin]]

Comment on attachment 9127079 [details] [diff] [review]
bug1615714_mac_hiddenwin.patch

Review of attachment 9127079 [details] [diff] [review]:
-----------------------------------------------------------------

We should

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/35335f53d59d