1615987 - [Thunderbird Telemetry] collect account setup success rate

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Magnus Melin [:mkmelin]]

It would be useful to know how well we're able (or not) to set up the accounts for people. We should set up a probe to collect success of automatic setup. It should also record whether you had to do a manual (successful) setup.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: 1615987.patch

Not sure if I understand the task correctly. This patch added a scalar probe to collect email account setup result, this probe has three keys: success_automatic, success_manual, failed

Haven't figured out how to add tests for this.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9154469 [details] [diff] [review]
1615987.patch

Review of attachment 9154469 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should instead collect the source - see https://searchfox.org/comm-central/rev/e8cc4c6395d4f9e128e04fc8c4163aa09b35d731/mail/components/accountcreation/content/accountConfig.js#342-345
Let's just also in the source stop having those be numbers. That's kind of pointless in JavaScript... They could just be "user", "ispdb", "guess", "autodiscover".

Our account setup is unfortunately poorly tested, but I think you could tag the testing along in https://searchfox.org/comm-central/source/mail/test/browser/account/browser_mailAccountSetupWizard.js

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: 1615987.patch

• Changed account config source to string
• Added a small test

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9154849 [details] [diff] [review]
1615987.patch

Review of attachment 9154849 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good to me. r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d442cd2eee15
Collect account setup success rate. r=mkmelin DONTBUILD

Comment 6

[Magnus Melin [:mkmelin]]

Actually we have a few sub-types of "xml". From xml-from-disk, xml-from-isp. https://searchfox.org/comm-central/rev/af886b93f1a520cb98cb6c0e3eda612a1caf2560/mail/components/accountcreation/content/emailWizard.js#732,742,761

We for the from isp case we could also distinguish which of the URLs we look at it used. And, if http or https was used. Can you file a bug for this?

Comment 7

[Magnus Melin [:mkmelin]]

Filed as bug 1644311.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9154849 [details] [diff] [review]
1615987.patch

Telemetry addition - not risky.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9154849 [details] [diff] [review]
1615987.patch

Approved for beta

Comment 10

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b6aec7a1e037