1616298 - Add ULEB128Reader class

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The new Fission-friendly profiler will use more "interesting" storage for which a proper iterator would be a bit harder to implement, so I'm implementing a ULEB128 reader class that can be fed bytes one at a time (instead of one function that controls an iterator).

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1616298 - Run BaseProfiler-independent tests even when BaseProfiler is not built - r?canaltinova!,gregtatum

Some of the BaseProfile headers are always available, even when BaseProfiler
itself is disabled, so we should test these in all cases.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1616298 - ULEB128Reader - r?canaltinova!,gregtatum

Unsigned LEB128 parser class that can be feb bytes one by one.

Depends on D63230

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3920eccb1ac
Run BaseProfiler-independent tests even when BaseProfiler is disabled - r=gregtatum,canaltinova
https://hg.mozilla.org/integration/autoland/rev/781be7f64b1a
ULEB128Reader - r=canaltinova

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1616298)for causing build bustages on TestBaseProfiler.cpp

Backout revision https://hg.mozilla.org/integration/autoland/rev/6a67e55ba1ed65dc6e46e688a03d9eef34510a27

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=781be7f64b1a0bd5211e39d1c6d73e0e5baad37f&searchStr=build

Failrue log https://treeherder.mozilla.org/logviewer.html#?job_id=290413072&repo=autoland

Gerald can you please take a look?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4e2f2fc7f37
Run BaseProfiler-independent tests even when BaseProfiler is not built - r=gregtatum,canaltinova
https://hg.mozilla.org/integration/autoland/rev/2bc6aa6e25e2
ULEB128Reader - r=canaltinova

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c4e2f2fc7f37
https://hg.mozilla.org/mozilla-central/rev/2bc6aa6e25e2