1616847 - HTMLTooltip with xulWrapper can't be moved if not hidden first

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Given an HTMLTooltip element with useXulWrapper set to true.

1. Calling show a first time will show the popup
2. Calling show a second time, with different anchor/position won't update the popup position.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1616847 - When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.

If the XUL wrapper was opened and a consumer called showXulWrapperAt again,
the panel wouldn't update its position. This can be fixed by checking the
state of the element, and if it's open move the panel using moveTo.

Depends on D63485

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df563f103355
When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.

Comment 3

[Daniel Varga [:dvarga]]

Backed out changeset df563f103355 (Bug 1616847) for causing devtools failure at devtools/client/shared/test/browser_html_tooltip_offset.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=df563f10335556bca5c1853e8fe78dacf2a9bf87

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290254641&repo=autoland&lineNumber=19350

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=290254816&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=dd2fa5793be60ddd521575715867674c63116042

[task 2020-02-24T21:18:43.847Z] 21:18:43     INFO - TEST-PASS | devtools/client/shared/test/browser_html_tooltip_offset.js | Tooltip height is at 100px as expected - 
[task 2020-02-24T21:18:43.848Z] 21:18:43     INFO - Display the tooltip on box2.
[task 2020-02-24T21:18:43.848Z] 21:18:43     INFO - Buffered messages finished
[task 2020-02-24T21:18:43.849Z] 21:18:43     INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_html_tooltip_offset.js | Test timed out - 
[task 2020-02-24T21:18:43.850Z] 21:18:43     INFO - TEST-PASS | devtools/client/shared/test/browser_html_tooltip_offset.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-02-24T21:18:43.850Z] 21:18:43     INFO - GECKO(5545) | MEMORY STAT | vsize 3240MB | residentFast 369MB | heapAllocated 120MB
[task 2020-02-24T21:18:43.851Z] 21:18:43     INFO - TEST-OK | devtools/client/shared/test/browser_html_tooltip_offset.js | took 45016ms
[task 2020-02-24T21:18:43.852Z] 21:18:43     INFO - checking window state
[task 2020-02-24T21:18:43.852Z] 21:18:43     INFO - TEST-START | devtools/client/shared/test/browser_html_tooltip_resize.js
[task 2020-02-24T21:18:43.853Z] 21:18:43     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-24T21:18:43.854Z] 21:18:43     INFO - Buffered messages logged at 21:18:43
[task 2020-02-24T21:18:43.855Z] 21:18:43     INFO - Entering test bound 
[task 2020-02-24T21:18:43.856Z] 21:18:43     INFO - Test resizing of a tooltip
[task 2020-02-24T21:18:43.856Z] 21:18:43     INFO - Buffered messages finished
[task 2020-02-24T21:18:43.857Z] 21:18:43     INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_html_tooltip_resize.js | Panel should have moved 100px to the right (actual: panel right: -680.9166870117188->199.0833282470703) - 
[task 2020-02-24T21:18:43.857Z] 21:18:43     INFO - Stack trace:
[task 2020-02-24T21:18:43.858Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2020-02-24T21:18:43.859Z] 21:18:43     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/browser_html_tooltip_resize.js:null:60
[task 2020-02-24T21:18:43.859Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-24T21:18:43.859Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-24T21:18:43.860Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-24T21:18:43.860Z] 21:18:43     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914
[task 2020-02-24T21:18:43.861Z] 21:18:43     INFO - TEST-PASS | devtools/client/shared/test/browser_html_tooltip_resize.js | Panel should have moved 10px down (actual: panel top: -49->-39) - 
[task 2020-02-24T21:18:43.862Z] 21:18:43     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-24T21:18:43.863Z] 21:18:43     INFO - TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_html_tooltip_resize.js | Arrow should not have moved (actual: arrow left: -773.4166870117188->7.083333492279053) - 
[task 2020-02-24T21:18:43.863Z] 21:18:43     INFO - Stack trace:
[task 2020-02-24T21:18:43.864Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2020-02-24T21:18:43.864Z] 21:18:43     INFO - chrome://mochitests/content/browser/devtools/client/shared/test/browser_html_tooltip_resize.js:null:79
[task 2020-02-24T21:18:43.864Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-24T21:18:43.865Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-24T21:18:43.865Z] 21:18:43     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-24T21:18:43.866Z] 21:18:43     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

new TRY push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3642e13be846f0b0178beba0237e376b0aa07afb

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2357c3d7aa4a
When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91d11cd8ab56
Backed out 2 changesets (bug 1616847, bug 1609942) for devtools failures on browser_jsterm_autocomplete_getters_cache.js.

Comment 7

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=%28dt&revision=0ee1ac6bab06c59b527637feaec3d8b69431777a&selectedJob=290629209

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=290629209&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/91d11cd8ab56e59da4bebdb959327e6749866b77

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

will push another patch soon

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a5178ee8cd2
When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_jsterm_autocomplete_control_space.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/545c4bc6235e7f3db4f314d96363b5061dbe3699
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291021342&repo=autoland&lineNumber=55685

There were also TV failures on browser_jsterm_autocomplete_getters_cache.js: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291000505&repo=autoland&lineNumber=7499

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

I think I got rid of the failures, let's see https://treeherder.mozilla.org/#/jobs?repo=try&revision=336e9a364066a6c96f49b31ecad9e1ca70a95ea2

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a8821347dd8
When xulWrapper is visible move it instead of trying to show it again. r=jdescottes.

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2a8821347dd8