1616958 - Bake collections into hard coded layout

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

This is needed to run our collections experiment.

For non experiment users, there should be no regressions around spocs.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: merging 2 hardcoded layouts into 1

Comment 2

[Phabricator Automation]

Comment on attachment 9128584 [details]
merging 2 hardcoded layouts into 1

Revision D63932 was moved to bug 1589248. Setting attachment 9128584 [details] to obsolete.

Comment 3

[Gavin Suntop [:gvn] (they/them)]

Attachment: adding collection to hardcoded layout

Comment 4

[Gavin Suntop [:gvn] (they/them)]

Test steps:

1. Set browser.newtabpage.activity-stream.discoverystream.spocs-endpoint to https://spocs.getpocket.com/spocs?site=1116390
2. Verify that you see the Story Collection

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b083d75af5f9
adding collection to hardcoded layout r=thecount

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/657123c2f8de
Backed out changeset b083d75af5f9 for linux newtab failures CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a47da31e0be4
adding collection to hardcoded layout r=thecount CLOSED TREE

Comment 8

[Stefan Hindli [:stefan_hindli]]

Backed out changeset a47da31e0be4 (Bug 1616958) for linux newtabfailure CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b083d75af5f93870e312d4e2f8462d7d43cf3bca&selectedJob=290839700

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290839700&repo=autoland&lineNumber=126

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f69978138a
Backed out changeset a47da31e0be4 for linux newtabfailure CLOSED TREE

Comment 10

[Gavin Suntop [:gvn] (they/them)]

Fixed tests. Re-landing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da0365b430c6
adding collection to hardcoded layout r=thecount

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/da0365b430c6

Comment 13

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the “Story Collection” is displayed by following the steps from comment 4, with the browser.search.region pref value set to US, using Firefox Nightly 75.0a1 (Build ID: 20200302212732) on Windows 10 x64, macOS 10.15, Ubuntu Linux 18.04 x64.